RESOLVED FIXED 185523
Renamed "trackNetworkActivity" to "tracksResourceLoadMilestone" 
https://bugs.webkit.org/show_bug.cgi?id=185523
Summary Renamed "trackNetworkActivity" to "tracksResourceLoadMilestone"
Keith Rollin
Reported 2018-05-10 12:04:02 PDT
Follow on to Bug 184838, comment 17. Note that that comment recommends incorporating the verb "should", but Geoff recommended against that, so I'm going with "tracks".
Attachments
Patch (14.04 KB, patch)
2018-05-10 12:08 PDT, Keith Rollin 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews206 for win-future (12.73 MB, application/zip)
2018-05-10 14:18 PDT, EWS Watchlist 		no flags
Details
Patch (14.27 KB, patch)
2018-05-17 12:18 PDT, Keith Rollin 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews200 for win-future (12.82 MB, application/zip)
2018-05-18 07:21 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-05-10 12:04:17 PDT
<rdar://problem/40136361>
Keith Rollin
Comment 2 2018-05-10 12:08:58 PDT
Created attachment 340116 [details] Patch
Chris Dumez
Comment 3 2018-05-10 12:17:08 PDT
Comment on attachment 340116 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340116&action=review > Source/WebKit/ChangeLog:3 > + Renamed "trackNetworkActivity" to "tracksResourceLoadMilestone" tracksResourceLoadMilestones
EWS Watchlist
Comment 4 2018-05-10 14:17:51 PDT
Comment on attachment 340116 [details] Patch Attachment 340116 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7642144 New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html http/tests/preload/onload_event.html
EWS Watchlist
Comment 5 2018-05-10 14:18:04 PDT
Created attachment 340130 [details] Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Keith Rollin
Comment 6 2018-05-17 12:18:47 PDT
Created attachment 340622 [details] Patch
EWS Watchlist
Comment 7 2018-05-18 07:20:51 PDT
Comment on attachment 340622 [details] Patch Attachment 340622 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7721704 New failing tests: http/tests/preload/onload_event.html
EWS Watchlist
Comment 8 2018-05-18 07:21:02 PDT
Created attachment 340692 [details] Archive of layout-test-results from ews200 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Geoffrey Garen
Comment 9 2018-05-18 10:34:31 PDT
Comment on attachment 340622 [details] Patch r=me
WebKit Commit Bot
Comment 10 2018-05-18 11:17:33 PDT
Comment on attachment 340622 [details] Patch Clearing flags on attachment: 340622 Committed r231966: <https://trac.webkit.org/changeset/231966>
WebKit Commit Bot
Comment 11 2018-05-18 11:17:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.