Bug 185514

Summary:

test262/Runner.pm: isolate runner's dependency on 5.8.8

Product:

WebKit

Reporter:

valerie <valerie>

Component:

JavaScriptCore

Assignee:

valerie <valerie>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

achristensen, commit-queue, ews-watchlist, leo, msaboff, valerie, webkit-bug-importer, webkit-unassigned

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews204 for win-future	none

valerie

Reported 2018-05-10 09:26:12 PDT

test262/Runner.pm has an unusual dependency on 5.8.8 -- but it currently calls out to a WebKit perl module webkitdirs.pm which has post-5.8.8 functionality. We explored making the external script compliant with perl 5.8.8 (in this bug: https://bugs.webkit.org/show_bug.cgi?id=185316) but concluded it is unreasonable to expect WebKit developers to keep other perl modules 5.8.8 compatible going forward. Current plan is to make a 5.8.8 compliant copy of webkitdirs.pm in webkit/Tools/Scripts/test262/ and add tests to make sure the functionality is in sync with `webkit-build-directory`.

Attachments
Patch (184.56 KB, patch) 2018-05-14 08:15 PDT, valerie	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews204 for win-future (12.79 MB, application/zip) 2018-05-14 11:16 PDT, EWS Watchlist	no flags	Details
View All Add attachment proposed patch, testcase, etc.

valerie

Comment 1 2018-05-14 08:15:26 PDT

Created attachment 340316 [details] Patch

Michael Saboff

Comment 2 2018-05-14 08:59:29 PDT

What is the dependency of the test262 on 5.8.8? Why can’t the runner change to work with newer versions?

EWS Watchlist

Comment 3 2018-05-14 11:15:55 PDT

Comment on attachment 340316 [details] Patch Attachment 340316 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7679008 New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html

EWS Watchlist

Comment 4 2018-05-14 11:16:06 PDT

Created attachment 340334 [details] Archive of layout-test-results from ews204 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews204 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

valerie

Comment 5 2018-06-12 13:27:21 PDT

Decided against this route

Alex Christensen

Comment 6 2021-11-01 12:17:34 PDT

Comment on attachment 340316 [details] Patch This has been requesting review for more than one year. If this is still needed, please rebase and re-request review.

Note You need to log in before you can comment on or make changes to this bug.