| Summary: | [GTK] Implement ImageBuffer::toBGRAData | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Thibault Saunier <tsaunier> | ||||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | bugs-noreply, commit-queue, mcatanzaro, tsaunier, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Thibault Saunier
2018-05-10 05:45:34 PDT
Created attachment 340086 [details]
[GTK] Implement ImageBuffer::toBGRAData
This was never implemented but will is required for the MediaStream API
tests.
Created attachment 340087 [details]
Minor typo fix since previous version.
Comment on attachment 340087 [details] Minor typo fix since previous version. View in context: https://bugs.webkit.org/attachment.cgi?id=340087&action=review > Source/WebCore/ChangeLog:8 > + [GTK] Implement ImageBuffer::toBGRAData The commit title doesn't belong here, you already have it properly up at the top. > Source/WebCore/platform/graphics/ImageBuffer.cpp:105 > +#if USE(CG) && !PLATFORM(GTK) Move the CG implementation to ImageBufferCG.cpp, then this condition can become #if !USE(CG) && !PLATFORM(GTK). Created attachment 340088 [details] (In reply to Michael Catanzaro from comment #3) > Comment on attachment 340087 [details] > Minor typo fix since previous version. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=340087&action=review > > > Source/WebCore/ChangeLog:8 > > + [GTK] Implement ImageBuffer::toBGRAData > > The commit title doesn't belong here, you already have it properly up at the > top. Not sure how that happened, I just used prepareChangeLog, anyway Fixed. > > Source/WebCore/platform/graphics/ImageBuffer.cpp:105 > > +#if USE(CG) && !PLATFORM(GTK) > > Move the CG implementation to ImageBufferCG.cpp, then this condition can > become #if !USE(CG) && !PLATFORM(GTK). Done. Comment on attachment 340088 [details] (In reply to Michael Catanzaro from comment #3) Clearing flags on attachment: 340088 Committed r231638: <https://trac.webkit.org/changeset/231638> All reviewed patches have been landed. Closing bug. |