Bug 185497

Summary:

Markup.dump should dump selection focus & anchor at the root node

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Tools / Tests

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, cdumez, ews-watchlist, lforschler, rniwa, simon.fraser, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

185465

Attachments:

Description	Flags
Improves Markup	none
Archive of layout-test-results from ews104 for mac-sierra-wk2	none
Archive of layout-test-results from ews100 for mac-sierra	none
Archive of layout-test-results from ews126 for ios-simulator-wk2	none
Archive of layout-test-results from ews116 for mac-sierra	none
Improves Markup.dump	wenson_hsieh: review+

Ryosuke Niwa

Reported 2018-05-09 16:44:58 PDT

Right now, Markup.dump doesn't log the selection anchor or the selection focus when their container node is the root node passed to Markup.dump. This is inconvenient since it's common for the caret / selection's end points to be anchored at the root editable element, which is typically the root node passed to Markup.dump.

Attachments
Improves Markup (22.99 KB, patch) 2018-05-09 16:55 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-sierra-wk2 (3.11 MB, application/zip) 2018-05-09 17:54 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews100 for mac-sierra (2.31 MB, application/zip) 2018-05-09 17:59 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (12.27 MB, application/zip) 2018-05-09 18:39 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews116 for mac-sierra (3.21 MB, application/zip) 2018-05-09 19:18 PDT, EWS Watchlist	no flags	Details
Improves Markup.dump (37.92 KB, patch) 2018-05-09 21:41 PDT, Ryosuke Niwa	wenson_hsieh: review+	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2018-05-09 16:55:54 PDT

Created attachment 340052 [details] Improves Markup

EWS Watchlist

Comment 2 2018-05-09 17:54:10 PDT

Comment on attachment 340052 [details] Improves Markup Attachment 340052 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7630893 New failing tests: editing/deleting/delete-emoji-9.html editing/deleting/delete-emoji-8.html editing/deleting/delete-emoji-6.html editing/deleting/delete-emoji-1.html editing/deleting/delete-emoji-4.html editing/deleting/delete-emoji-2.html editing/deleting/delete-emoji-3.html editing/deleting/delete-emoji-5.html editing/deleting/delete-emoji-7.html

EWS Watchlist

Comment 3 2018-05-09 17:54:11 PDT

Created attachment 340055 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 4 2018-05-09 17:59:39 PDT

Comment on attachment 340052 [details] Improves Markup Attachment 340052 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7630945 New failing tests: editing/deleting/delete-emoji-9.html editing/deleting/delete-emoji-8.html editing/deleting/delete-emoji-6.html editing/deleting/delete-emoji-1.html editing/deleting/delete-emoji-4.html editing/deleting/delete-emoji-2.html fast/events/5056619.html editing/deleting/delete-emoji-3.html editing/deleting/delete-emoji-5.html editing/deleting/delete-emoji-7.html

EWS Watchlist

Comment 5 2018-05-09 17:59:41 PDT

Created attachment 340056 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6

Ryosuke Niwa

Comment 6 2018-05-09 18:00:57 PDT

Ugh... looks like macOS Sierra has its own expectations for these layout tests :(

EWS Watchlist

Comment 7 2018-05-09 18:39:24 PDT

Comment on attachment 340052 [details] Improves Markup Attachment 340052 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/7631042 New failing tests: editing/deleting/delete-emoji-9.html editing/deleting/delete-emoji-8.html editing/deleting/delete-emoji-6.html editing/deleting/delete-emoji-1.html editing/deleting/delete-emoji.html editing/deleting/delete-emoji-4.html editing/deleting/delete-emoji-2.html editing/deleting/delete-emoji-3.html editing/deleting/delete-emoji-5.html editing/deleting/delete-emoji-7.html

EWS Watchlist

Comment 8 2018-05-09 18:39:26 PDT

Created attachment 340059 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4

EWS Watchlist

Comment 9 2018-05-09 19:18:48 PDT

Comment on attachment 340052 [details] Improves Markup Attachment 340052 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/7631316 New failing tests: editing/deleting/delete-emoji-9.html editing/deleting/delete-emoji-8.html editing/deleting/delete-emoji-6.html editing/deleting/delete-emoji-1.html editing/deleting/delete-emoji-4.html editing/deleting/delete-emoji-2.html fast/events/5056619.html editing/deleting/delete-emoji-3.html editing/deleting/delete-emoji-5.html editing/deleting/delete-emoji-7.html

EWS Watchlist

Comment 10 2018-05-09 19:18:50 PDT

Created attachment 340063 [details] Archive of layout-test-results from ews116 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-sierra Platform: Mac OS X 10.12.6

Ryosuke Niwa

Comment 11 2018-05-09 21:41:03 PDT

Created attachment 340067 [details] Improves Markup.dump

Ryosuke Niwa

Comment 12 2018-05-09 22:46:49 PDT

Thanks for the review!

Ryosuke Niwa

Comment 13 2018-05-09 23:39:03 PDT

Committed r231630: <https://trac.webkit.org/changeset/231630>

Radar WebKit Bug Importer

Comment 14 2018-05-09 23:41:39 PDT

<rdar://problem/40120165>

Alexey Proskuryakov

Comment 15 2018-05-10 09:06:40 PDT

Nice! But looks like Windows results will need to be updated too?

Ryosuke Niwa

Comment 16 2018-05-10 13:35:42 PDT

(In reply to Alexey Proskuryakov from comment #15) > Nice! But looks like Windows results will need to be updated too? Hm... I thought there were no Windows specific results. Do you have any links to Windows bots where you're seeing failures?

Note You need to log in before you can comment on or make changes to this bug.