Bug 185486

Summary: Update WebKit.WebsiteDataStoreCustomPaths after r231536
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: Tools / TestsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dbates, ggaren, lforschler, sihui_liu, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Sihui Liu
Reported 2018-05-09 13:21:38 PDT
_syncNetworkProcessCookies is completely async after r231536, so we need to update the test using this API.
Attachments
Patch (1.78 KB, patch)
2018-05-09 13:31 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch (1.77 KB, patch)
2018-05-09 14:35 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 1 2018-05-09 13:23:06 PDT
<rdar://problem/37214391>
Sihui Liu
Comment 2 2018-05-09 13:31:58 PDT
Created attachment 340015 [details] Patch
Chris Dumez
Comment 3 2018-05-09 13:35:07 PDT
Comment on attachment 340015 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340015&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:150 > + TestWebKitAPI::Util::spinRunLoop(1); I am worried this could still be flaky. How do we know that spinning the runloop 10 times will be sufficient for us: 1. Sending the async IPC to the network process 2. The network process receiving the IPC and asking CFNetwork do sync the cookies 3. Cookies are done sync'ing by the CFNetwork.
Sihui Liu
Comment 4 2018-05-09 14:35:01 PDT
Created attachment 340028 [details] Patch
Sihui Liu
Comment 5 2018-05-09 14:37:23 PDT
(In reply to Chris Dumez from comment #3) > Comment on attachment 340015 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=340015&action=review > > > Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:150 > > + TestWebKitAPI::Util::spinRunLoop(1); > > I am worried this could still be flaky. How do we know that spinning the > runloop 10 times will be sufficient for us: > 1. Sending the async IPC to the network process > 2. The network process receiving the IPC and asking CFNetwork do sync the > cookies > 3. Cookies are done sync'ing by the CFNetwork. We don't know. I've changed it to use sleep since second seems to be a better unit for estimation.
Chris Dumez
Comment 6 2018-05-09 14:40:59 PDT
Comment on attachment 340028 [details] Patch I would have been more generous than 3 seconds given our slow bots but let's try...
WebKit Commit Bot
Comment 7 2018-05-09 15:35:44 PDT
Comment on attachment 340028 [details] Patch Clearing flags on attachment: 340028 Committed r231603: <https://trac.webkit.org/changeset/231603>
WebKit Commit Bot
Comment 8 2018-05-09 15:35:45 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2018-05-09 16:09:00 PDT
<rdar://problem/40110684>
Alexey Proskuryakov
Comment 10 2018-05-09 23:22:00 PDT
Comment on attachment 340028 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340028&action=review > Tools/ChangeLog:9 > + Update WebKit.WebsiteDataStoreCustomPaths as _syncNetworkProcessCookies is async now. "_syncNetworkProcessCookies is async"...
Chris Dumez
Comment 11 2018-05-10 07:01:23 PDT
(In reply to Alexey Proskuryakov from comment #10) > Comment on attachment 340028 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=340028&action=review > > > Tools/ChangeLog:9 > > + Update WebKit.WebsiteDataStoreCustomPaths as _syncNetworkProcessCookies is async now. > > "_syncNetworkProcessCookies is async"... Sync means synchronize here, not synchronous :)
Note You need to log in before you can comment on or make changes to this bug.