Bug 185481

Summary: [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess
Product: WebKit Reporter: Thibault Saunier <tsaunier>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, glenn, pnormand, tsaunier, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess none

Thibault Saunier
Reported 2018-05-09 11:25:47 PDT
.
Attachments
[tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess (1.88 KB, patch)
2018-05-09 11:31 PDT, Thibault Saunier 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Thibault Saunier
Comment 1 2018-05-09 11:31:15 PDT
Created attachment 339993 [details] [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess
Philippe Normand
Comment 2 2018-05-09 11:48:27 PDT
Comment on attachment 339993 [details] [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess This is a bit premature? I think we should first bump the jhbuild to 1.14.
Thibault Saunier
Comment 3 2018-05-09 11:53:30 PDT
(In reply to Philippe Normand from comment #2) > Comment on attachment 339993 [details] > [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess > > This is a bit premature? I think we should first bump the jhbuild to 1.14. Well, this is only so that we have a way to run tests against playbin3, this is totally opt-in and it is very unlikely someone set USE_PLAYBIN3 without knowing what he is doing fmpov.
Philippe Normand
Comment 4 2018-05-09 12:09:08 PDT
Comment on attachment 339993 [details] [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess Oh right, I totally misread the patch :) lgtm!
WebKit Commit Bot
Comment 5 2018-05-09 12:14:08 PDT
Comment on attachment 339993 [details] [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess Clearing flags on attachment: 339993 Committed r231584: <https://trac.webkit.org/changeset/231584>
WebKit Commit Bot
Comment 6 2018-05-09 12:14:09 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-05-09 12:27:47 PDT
<rdar://problem/40101847>
Note You need to log in before you can comment on or make changes to this bug.