Bug 185465

Summary: Tapping after CSS-based table casues an infinite loop in wordRangeFromPosition
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, koivisto, rniwa, simon.fraser, wenson_hsieh, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 185497    
Bug Blocks:    
Attachments:
Description Flags
Reduction
none
WIP1
ews-watchlist: commit-queue-
Archive of layout-test-results from ews100 for mac-sierra
none
Archive of layout-test-results from ews104 for mac-sierra-wk2
none
Archive of layout-test-results from ews116 for mac-sierra
none
Archive of layout-test-results from ews123 for ios-simulator-wk2
none
Archive of layout-test-results from ews204 for win-future
none
WIP2
none
Fixes the hang none

Description Ryosuke Niwa 2018-05-08 23:38:01 PDT
Tapping on a space after a CSS-based table causes a hang inside wordRangeFromPosition.
Comment 1 Ryosuke Niwa 2018-05-08 23:39:09 PDT
Created attachment 339933 [details]
Reduction
Comment 2 Ryosuke Niwa 2018-05-08 23:40:54 PDT
Created attachment 339934 [details]
WIP1
Comment 3 Ryosuke Niwa 2018-05-08 23:41:11 PDT
<rdar://problem/35263057>
Comment 4 EWS Watchlist 2018-05-09 00:45:11 PDT
Comment on attachment 339934 [details]
WIP1

Attachment 339934 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/7620890

New failing tests:
fast/html/marquee-reparent-check.html
fast/spatial-navigation/snav-radio-group.html
Comment 5 EWS Watchlist 2018-05-09 00:45:12 PDT
Created attachment 339939 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 6 EWS Watchlist 2018-05-09 00:50:16 PDT
Comment on attachment 339934 [details]
WIP1

Attachment 339934 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7620897

New failing tests:
fast/html/marquee-reparent-check.html
Comment 7 EWS Watchlist 2018-05-09 00:50:18 PDT
Created attachment 339941 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 8 EWS Watchlist 2018-05-09 01:15:17 PDT
Comment on attachment 339934 [details]
WIP1

Attachment 339934 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/7620915

New failing tests:
fast/spatial-navigation/snav-radio-group.html
Comment 9 EWS Watchlist 2018-05-09 01:15:19 PDT
Created attachment 339942 [details]
Archive of layout-test-results from ews116 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 10 EWS Watchlist 2018-05-09 01:22:35 PDT
Comment on attachment 339934 [details]
WIP1

Attachment 339934 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/7620930

New failing tests:
fast/html/marquee-reparent-check.html
Comment 11 EWS Watchlist 2018-05-09 01:22:37 PDT
Created attachment 339944 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4
Comment 12 EWS Watchlist 2018-05-09 03:32:16 PDT
Comment on attachment 339934 [details]
WIP1

Attachment 339934 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7621732

New failing tests:
fast/html/marquee-reparent-check.html
fast/spatial-navigation/snav-radio-group.html
Comment 13 EWS Watchlist 2018-05-09 03:32:27 PDT
Created attachment 339951 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 14 Ryosuke Niwa 2018-05-09 11:09:29 PDT
Created attachment 339985 [details]
WIP2
Comment 15 Ryosuke Niwa 2018-05-10 14:59:25 PDT
Created attachment 340135 [details]
Fixes the hang
Comment 16 Ryosuke Niwa 2018-05-11 13:12:29 PDT
Comment on attachment 340135 [details]
Fixes the hang

Thanks for the review!
Comment 17 WebKit Commit Bot 2018-05-11 13:39:36 PDT
Comment on attachment 340135 [details]
Fixes the hang

Clearing flags on attachment: 340135

Committed r231717: <https://trac.webkit.org/changeset/231717>
Comment 18 WebKit Commit Bot 2018-05-11 13:39:38 PDT
All reviewed patches have been landed.  Closing bug.