Bug 185457

Summary:

Speed up AbstractInterpreter::executeEdges

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	fpizlo: review-
more	none
the patch	saam: review+

Filip Pizlo

Reported 2018-05-08 16:49:08 PDT

Patch forthcoming.

Attachments
the patch (3.30 KB, patch) 2018-05-08 16:50 PDT, Filip Pizlo	fpizlo: review-	Details Formatted Diff Diff
more (19.26 KB, patch) 2018-05-08 22:16 PDT, Filip Pizlo	no flags	Details Formatted Diff Diff
the patch (23.18 KB, patch) 2018-05-09 12:20 PDT, Filip Pizlo	saam: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2018-05-08 16:50:28 PDT

Created attachment 339900 [details] the patch

Filip Pizlo

Comment 2 2018-05-08 16:51:19 PDT

Comment on attachment 339900 [details] the patch This doesn't achieve what I wanted it to.

Filip Pizlo

Comment 3 2018-05-08 22:16:40 PDT

Created attachment 339929 [details] more This turned into an adventure. It's probably not over.

Filip Pizlo

Comment 4 2018-05-09 12:20:17 PDT

Created attachment 340001 [details] the patch

EWS Watchlist

Comment 5 2018-05-09 12:22:10 PDT

Attachment 340001 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreter.h:248: The parameter name "edge" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreter.h:248: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.

Saam Barati

Comment 6 2018-05-09 13:39:44 PDT

Comment on attachment 340001 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=340001&action=review r=me but I think you have a function you forgot to call for the fast path > Source/JavaScriptCore/ChangeLog:31 > + But that fix revealed an amazing timeout in what an adventure > Source/JavaScriptCore/dfg/DFGAbstractValue.h:343 > + ALWAYS_INLINE FiltrationResult fastForwardToAndFilter(AbstractValueClobberEpoch newEpoch, SpeculatedType type) This doesn't seem to be called from anywhere. Maybe InPlaceAbstractState was supposed to call this instead of the below function?

Filip Pizlo

Comment 7 2018-05-09 16:27:06 PDT

(In reply to Saam Barati from comment #6) > Comment on attachment 340001 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=340001&action=review > > r=me > but I think you have a function you forgot to call for the fast path > > > Source/JavaScriptCore/ChangeLog:31 > > + But that fix revealed an amazing timeout in > > what an adventure > > > Source/JavaScriptCore/dfg/DFGAbstractValue.h:343 > > + ALWAYS_INLINE FiltrationResult fastForwardToAndFilter(AbstractValueClobberEpoch newEpoch, SpeculatedType type) > > This doesn't seem to be called from anywhere. Maybe InPlaceAbstractState was > supposed to call this instead of the below function? No, I added this function for "completeness". I'll remove it.

Filip Pizlo

Comment 8 2018-05-09 16:31:32 PDT

Landed in https://trac.webkit.org/changeset/231607/webkit

Radar WebKit Bug Importer

Comment 9 2018-05-09 17:16:38 PDT

<rdar://problem/40113141>

Note You need to log in before you can comment on or make changes to this bug.