Bug 185457 – Speed up AbstractInterpreter::executeEdges

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

Patch forthcoming.

[Filip Pizlo]

Created attachment 339900 [details]
the patch

[Filip Pizlo]

Comment on attachment 339900 [details]
the patch

This doesn't achieve what I wanted it to.

[Filip Pizlo]

Created attachment 339929 [details]
more

This turned into an adventure.  It's probably not over.

[Filip Pizlo]

Created attachment 340001 [details]
the patch

[EWS Watchlist]

Attachment 340001 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreter.h:248:  The parameter name "edge" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreter.h:248:  The parameter name "type" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Saam Barati]

Comment on attachment 340001 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340001&action=review

r=me
but I think you have a function you forgot to call for the fast path

> Source/JavaScriptCore/ChangeLog:31
> +        But that fix revealed an amazing timeout in

what an adventure

> Source/JavaScriptCore/dfg/DFGAbstractValue.h:343
> +    ALWAYS_INLINE FiltrationResult fastForwardToAndFilter(AbstractValueClobberEpoch newEpoch, SpeculatedType type)

This doesn't seem to be called from anywhere. Maybe InPlaceAbstractState was supposed to call this instead of the below function?

[Filip Pizlo]

(In reply to Saam Barati from comment #6)
> Comment on attachment 340001 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=340001&action=review
> 
> r=me
> but I think you have a function you forgot to call for the fast path
> 
> > Source/JavaScriptCore/ChangeLog:31
> > +        But that fix revealed an amazing timeout in
> 
> what an adventure
> 
> > Source/JavaScriptCore/dfg/DFGAbstractValue.h:343
> > +    ALWAYS_INLINE FiltrationResult fastForwardToAndFilter(AbstractValueClobberEpoch newEpoch, SpeculatedType type)
> 
> This doesn't seem to be called from anywhere. Maybe InPlaceAbstractState was
> supposed to call this instead of the below function?

No, I added this function for "completeness".  I'll remove it.

[Filip Pizlo]

Landed in https://trac.webkit.org/changeset/231607/webkit

[Radar WebKit Bug Importer]

<rdar://problem/40113141>