Bug 185442

Summary: Do not apply X-Frame-Options and CSP frame-ancestors to Quick Look-applicable responses in NetworkProcess
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, lforschler, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 185410    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch aestes: review+

Daniel Bates
Reported 2018-05-08 12:30:11 PDT
Do not apply X-Frame-Options and CSP frame-ancestors to QuickLooks-applicable responses in NetworkProcess.
Attachments
Patch (4.05 KB, patch)
2018-05-08 12:48 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (4.06 KB, patch)
2018-05-08 13:12 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (4.10 KB, patch)
2018-05-08 13:58 PDT, Daniel Bates 		aestes: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-05-08 12:32:22 PDT
<rdar://problem/40067209>
Daniel Bates
Comment 2 2018-05-08 12:48:47 PDT
Created attachment 339857 [details] Patch
Daniel Bates
Comment 3 2018-05-08 13:12:38 PDT
Created attachment 339860 [details] Patch
Daniel Bates
Comment 4 2018-05-08 13:58:42 PDT
Created attachment 339871 [details] Patch
Andy Estes
Comment 5 2018-05-08 16:12:35 PDT
Comment on attachment 339871 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339871&action=review > Source/WebKit/ChangeLog:9 > + Just as we exempt responses in WebContent process that will be handled by QuickLooks from the Content Quick Look, not QuickLooks
Daniel Bates
Comment 6 2018-05-08 16:24:27 PDT
(In reply to Andy Estes from comment #5) > Comment on attachment 339871 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=339871&action=review > > > Source/WebKit/ChangeLog:9 > > + Just as we exempt responses in WebContent process that will be handled by QuickLooks from the Content > > Quick Look, not QuickLooks Fixed bug title, will ChangeLog before landing.
Daniel Bates
Comment 7 2018-05-08 16:28:20 PDT
Committed r231521: <https://trac.webkit.org/changeset/231521>
Note You need to log in before you can comment on or make changes to this bug.