Bug 185439

Summary: System Preview links should trigger a download
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dbates, esprehn+autocc, ews-watchlist, gyuyoung.kim, japhet, jonlee, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch jonlee: review+

Dean Jackson
Reported 2018-05-08 11:44:29 PDT
System Preview links should trigger a download
Attachments
Patch (15.47 KB, patch)
2018-05-08 11:53 PDT, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Patch (15.59 KB, patch)
2018-05-08 12:02 PDT, Dean Jackson 		jonlee: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-05-08 11:45:19 PDT
<rdar://problem/40065545>
Dean Jackson
Comment 2 2018-05-08 11:53:06 PDT
Created attachment 339851 [details] Patch
Dean Jackson
Comment 3 2018-05-08 12:02:30 PDT
Created attachment 339853 [details] Patch
Dean Jackson
Comment 4 2018-05-08 13:12:43 PDT
Committed r231507: <https://trac.webkit.org/changeset/231507>
Simon Fraser (smfr)
Comment 5 2018-05-08 13:26:31 PDT
Comment on attachment 339853 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339853&action=review > Source/WebCore/platform/network/ResourceRequestBase.cpp:587 > +void ResourceRequestBase::setSystemPreview(bool s) > +{ > + m_isSystemPreview = s; > +} s :( > Source/WebCore/platform/network/ResourceRequestBase.h:236 > + bool m_isSystemPreview { false }; Please move the bools together for better packing.
Note You need to log in before you can comment on or make changes to this bug.