Bug 185437

Summary: Log rtcstats as JSON
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: WebRTCAssignee: Eric Carlson <eric.carlson>
Status: ASSIGNED    
Severity: Normal CC: commit-queue, ews-watchlist, rniwa, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-watchlist: commit-queue-
Patch for landing
none
Archive of layout-test-results from ews200 for win-future
none
Archive of layout-test-results from ews104 for mac-sierra-wk2 none

Eric Carlson
Reported 2018-05-08 11:39:08 PDT
libwebrtc now emits stats as well formed JSON, so log them as JSON to the inspector console so they are easier to understand.
Attachments
Patch (3.80 KB, patch)
2018-05-08 11:46 PDT, Eric Carlson 		ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (3.80 KB, patch)
2018-05-08 13:44 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews200 for win-future (12.80 MB, application/zip)
2018-05-08 14:17 PDT, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (2.90 MB, application/zip)
2018-05-08 14:43 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-05-08 11:39:46 PDT
<rdar://problem/40065332>
Eric Carlson
Comment 2 2018-05-08 11:46:22 PDT
Created attachment 339849 [details] Patch
youenn fablet
Comment 3 2018-05-08 11:49:08 PDT
Comment on attachment 339849 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339849&action=review > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:1048 > + RTCStatsLogger(const webrtc::RTCStats& stats) explicit probably. > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:1127 > + return WTF::String(logger.toJSONString()); Do we need WTF::?
Eric Carlson
Comment 4 2018-05-08 13:44:07 PDT
Created attachment 339867 [details] Patch for landing
EWS Watchlist
Comment 5 2018-05-08 14:16:56 PDT
Comment on attachment 339849 [details] Patch Attachment 339849 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7611407 New failing tests: http/tests/security/canvas-remote-read-remote-video-localhost.html
EWS Watchlist
Comment 6 2018-05-08 14:17:08 PDT
Created attachment 339876 [details] Archive of layout-test-results from ews200 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
WebKit Commit Bot
Comment 7 2018-05-08 14:22:36 PDT
Comment on attachment 339867 [details] Patch for landing Clearing flags on attachment: 339867 Committed r231512: <https://trac.webkit.org/changeset/231512>
EWS Watchlist
Comment 8 2018-05-08 14:43:15 PDT
Comment on attachment 339849 [details] Patch Attachment 339849 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7612131 New failing tests: http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html
EWS Watchlist
Comment 9 2018-05-08 14:43:17 PDT
Created attachment 339883 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Note You need to log in before you can comment on or make changes to this bug.