Bug 185427

Summary:

Add test to verify behavior of -webkit-text-fill-color when inherited

Product:

WebKit

Reporter:

Aditya Keerthi <pxlcoder>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dbates, emilio, ews-watchlist, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews107 for mac-sierra-wk2	none
Patch	none

Aditya Keerthi

Reported 2018-05-08 09:53:56 PDT

Add test to verify behavior of -webkit-text-fill-color when inherited In the case where the parent element does not define -webkit-text-fill-color, and the child element has '-webkit-text-fill-color: inherit', the child element's computed -webkit-text-fill-color should be the parent's color. This is because the initial value of fill-color is currentcolor. The child then takes on the parent's currentcolor, which is equivalent to the parent's color.

Attachments
Patch (2.34 KB, patch) 2018-05-08 09:57 PDT, Aditya Keerthi	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.10 MB, application/zip) 2018-05-08 12:31 PDT, EWS Watchlist	no flags	Details
Patch (1.93 KB, patch) 2018-05-11 14:38 PDT, Aditya Keerthi	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Aditya Keerthi

Comment 1 2018-05-08 09:57:57 PDT

Created attachment 339827 [details] Patch

Emilio Cobos Álvarez (:emilio)

Comment 2 2018-05-08 10:11:57 PDT

FWIW, at least per spec, currentColor isn't supposed to get resolved until resolved value time, so WebKit looks wrong here I think.

Aditya Keerthi

Comment 3 2018-05-08 10:22:45 PDT

What would the expected behavior be in this case? I was under the impression that currentcolor always takes on the value of the color attribute defined by the element.

EWS Watchlist

Comment 4 2018-05-08 12:31:00 PDT

Comment on attachment 339827 [details] Patch Attachment 339827 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7610032 New failing tests: css3/filters/backdrop/add-remove-add-backdrop-filter.html

EWS Watchlist

Comment 5 2018-05-08 12:31:01 PDT

Created attachment 339856 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Aditya Keerthi

Comment 6 2018-05-11 14:38:55 PDT

Created attachment 340223 [details] Patch

Daniel Bates

Comment 7 2018-05-11 18:22:31 PDT

Comment on attachment 340223 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340223&action=review Thank you for iterating on this patch, Aditya. r=me > LayoutTests/fast/css/webkit-text-fill-color-inherit.html:5 > + <div id="undefined-parent" style="color: red; -webkit-text-fill-color: inherit">Green</div> This is OK as-is. We are not using this id. > LayoutTests/fast/css/webkit-text-fill-color-inherit.html:8 > + <div id="defined-parent" style="color: red; -webkit-text-fill-color: inherit">Green</div> Ditto.

WebKit Commit Bot

Comment 8 2018-05-15 09:40:40 PDT

Comment on attachment 340223 [details] Patch Clearing flags on attachment: 340223 Committed r231805: <https://trac.webkit.org/changeset/231805>

WebKit Commit Bot

Comment 9 2018-05-15 09:40:42 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 10 2018-05-15 09:41:25 PDT

<rdar://problem/40259163>

Note You need to log in before you can comment on or make changes to this bug.