Bug 185427

Summary: Add test to verify behavior of -webkit-text-fill-color when inherited
Product: WebKit Reporter: Aditya Keerthi <pxlcoder>
Component: CSSAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: commit-queue, dbates, emilio, ews-watchlist, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Description Flags
Archive of layout-test-results from ews107 for mac-sierra-wk2
Patch none

Description Aditya Keerthi 2018-05-08 09:53:56 PDT
Add test to verify behavior of -webkit-text-fill-color when inherited

In the case where the parent element does not define -webkit-text-fill-color, and the child element has '-webkit-text-fill-color: inherit', the child element's computed -webkit-text-fill-color should be the parent's color. This is because the initial value of fill-color is currentcolor. The child then takes on the parent's currentcolor, which is equivalent to the parent's color.
Comment 1 Aditya Keerthi 2018-05-08 09:57:57 PDT
Created attachment 339827 [details]
Comment 2 Emilio Cobos Álvarez (:emilio) 2018-05-08 10:11:57 PDT
FWIW, at least per spec, currentColor isn't supposed to get resolved until resolved value time, so WebKit looks wrong here I think.
Comment 3 Aditya Keerthi 2018-05-08 10:22:45 PDT
What would the expected behavior be in this case?

I was under the impression that currentcolor always takes on the value of the color attribute defined by the element.
Comment 4 EWS Watchlist 2018-05-08 12:31:00 PDT
Comment on attachment 339827 [details]

Attachment 339827 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7610032

New failing tests:
Comment 5 EWS Watchlist 2018-05-08 12:31:01 PDT
Created attachment 339856 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 6 Aditya Keerthi 2018-05-11 14:38:55 PDT
Created attachment 340223 [details]
Comment 7 Daniel Bates 2018-05-11 18:22:31 PDT
Comment on attachment 340223 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=340223&action=review

Thank you for iterating on this patch, Aditya.

> LayoutTests/fast/css/webkit-text-fill-color-inherit.html:5
> +        <div id="undefined-parent" style="color: red; -webkit-text-fill-color: inherit">Green</div>

This is OK as-is. We are not using this id.

> LayoutTests/fast/css/webkit-text-fill-color-inherit.html:8
> +        <div id="defined-parent" style="color: red; -webkit-text-fill-color: inherit">Green</div>

Comment 8 WebKit Commit Bot 2018-05-15 09:40:40 PDT
Comment on attachment 340223 [details]

Clearing flags on attachment: 340223

Committed r231805: <https://trac.webkit.org/changeset/231805>
Comment 9 WebKit Commit Bot 2018-05-15 09:40:42 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2018-05-15 09:41:25 PDT