Summary: | Add test to verify behavior of -webkit-text-fill-color when inherited | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aditya Keerthi <pxlcoder> | ||||||||
Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, dbates, emilio, ews-watchlist, rniwa, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Aditya Keerthi
2018-05-08 09:53:56 PDT
Created attachment 339827 [details]
Patch
FWIW, at least per spec, currentColor isn't supposed to get resolved until resolved value time, so WebKit looks wrong here I think. What would the expected behavior be in this case? I was under the impression that currentcolor always takes on the value of the color attribute defined by the element. Comment on attachment 339827 [details] Patch Attachment 339827 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7610032 New failing tests: css3/filters/backdrop/add-remove-add-backdrop-filter.html Created attachment 339856 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Created attachment 340223 [details]
Patch
Comment on attachment 340223 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340223&action=review Thank you for iterating on this patch, Aditya. r=me > LayoutTests/fast/css/webkit-text-fill-color-inherit.html:5 > + <div id="undefined-parent" style="color: red; -webkit-text-fill-color: inherit">Green</div> This is OK as-is. We are not using this id. > LayoutTests/fast/css/webkit-text-fill-color-inherit.html:8 > + <div id="defined-parent" style="color: red; -webkit-text-fill-color: inherit">Green</div> Ditto. Comment on attachment 340223 [details] Patch Clearing flags on attachment: 340223 Committed r231805: <https://trac.webkit.org/changeset/231805> All reviewed patches have been landed. Closing bug. |