Bug 185421

Summary: [Win] Enable poisoning in 64bit Windows
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED WONTFIX    
Severity: Normal CC: benjamin, cdumez, cmarcelo, dbates, ews-watchlist, keith_miller, mark.lam, mjs, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
Patch
none
Patch
none
Patch mjs: review-

Yusuke Suzuki
Reported 2018-05-08 07:08:55 PDT
[Win] Enable poisoning in 64bit Windows
Attachments
WIP (5.68 KB, patch)
2018-05-08 07:09 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (11.53 KB, patch)
2018-05-09 06:02 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (12.16 KB, patch)
2018-05-09 10:58 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (12.16 KB, patch)
2018-05-09 11:09 PDT, Yusuke Suzuki 		mjs: review-
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-05-08 07:09:11 PDT
Created attachment 339815 [details] WIP
Yusuke Suzuki
Comment 2 2018-05-09 06:02:00 PDT
Created attachment 339959 [details] Patch
Yusuke Suzuki
Comment 3 2018-05-09 10:36:02 PDT
Comment on attachment 339959 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339959&action=review > Source/JavaScriptCore/offlineasm/x86.rb:67 > +# rcx => t5, a0 This is not correct. While t5 is actually rcx in baseline JIT side, this does not meet the requirement in LLInt.
Yusuke Suzuki
Comment 4 2018-05-09 10:58:20 PDT
Created attachment 339983 [details] Patch
Yusuke Suzuki
Comment 5 2018-05-09 11:04:46 PDT
Comment on attachment 339983 [details] Patch Not working well. Fixing.
Yusuke Suzuki
Comment 6 2018-05-09 11:09:58 PDT
Created attachment 339986 [details] Patch
Yusuke Suzuki
Comment 7 2018-05-09 11:13:38 PDT
OK, it is working :)
Maciej Stachowiak
Comment 8 2020-05-30 20:17:31 PDT
Comment on attachment 339986 [details] Patch Poisoning has been removed.
Note You need to log in before you can comment on or make changes to this bug.