Bug 18540

Summary: console.log('multiple', 'strings') quotes all strings after the first
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: http://svn.webkit.org/repository/webkit/trunk/WebCore/manual-tests/inspector/console-log-formatting.html
Attachments:
Description Flags
fix aroben: review+

Adam Roben (:aroben)
Reported 2008-04-16 13:20:53 PDT
console.log('multiple', 'strings') quotes all strings after the first one. For example: console.log('here', 'are', 'some', 'strings') Inspector's output: here "are" "some" "strings" Firebug's output: here are some strings We should match Firebug here.
Attachments
fix (1.44 KB, patch)
2008-07-10 01:07 PDT, Keishi Hattori 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Keishi Hattori
Comment 1 2008-07-10 01:07:05 PDT
Created attachment 22197 [details] fix Should I have written Object.type(parameters[i], InspectorController.inspectedWindow()) === "string" instead of typeof parameters[i] === "string" like on line 49 of Console.js? I kind of feel using Object.type is an overkill for detecting string.
Adam Roben (:aroben)
Comment 2 2008-07-10 08:07:01 PDT
Comment on attachment 22197 [details] fix It would be great to add a testcase just for this particular problem (though the issue can already be seen in existing testcases) r=me even without a testcase
Mark Rowe (bdash)
Comment 3 2008-07-26 22:14:27 PDT
Landed in r35383.
Note You need to log in before you can comment on or make changes to this bug.