| Summary: | console.log('multiple', 'strings') quotes all strings after the first | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||
| Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | ||||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| URL: | http://svn.webkit.org/repository/webkit/trunk/WebCore/manual-tests/inspector/console-log-formatting.html | ||||||
| Attachments: |
|
||||||
Created attachment 22197 [details]
fix
Should I have written
Object.type(parameters[i], InspectorController.inspectedWindow()) === "string"
instead of
typeof parameters[i] === "string"
like on line 49 of Console.js?
I kind of feel using Object.type is an overkill for detecting string.
Comment on attachment 22197 [details]
fix
It would be great to add a testcase just for this particular problem (though the issue can already be seen in existing testcases)
r=me even without a testcase
|
console.log('multiple', 'strings') quotes all strings after the first one. For example: console.log('here', 'are', 'some', 'strings') Inspector's output: here "are" "some" "strings" Firebug's output: here are some strings We should match Firebug here.