Bug 185392

Summary: test262/Runner.pm: create results dir for results of test262 run
Product: WebKit Reporter: valerie <valerie>
Component: JavaScriptCoreAssignee: valerie <valerie>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews, leo, msaboff, rniwa, valerie, webkit-bug-importer, webkit-unassigned
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=192547
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews107 for mac-sierra-wk2
none
Patch
none
Patch
none
Manually created patch for this bug
none
Add test262-results dir
none
Patch
none
patch none

Description valerie 2018-05-07 13:53:25 PDT
This patch:
- Creates a directory `results` and saves the results.yaml, summary.yaml and summary.txt files there
- adds a `--results` option to specify a results file, otherwise looks for a results directory wherever the script is ran
Comment 1 valerie 2018-05-07 13:59:17 PDT
Created attachment 339749 [details]
Patch
Comment 2 Michael Saboff 2018-05-07 15:31:41 PDT
Comment on attachment 339749 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339749&action=review

> Tools/Scripts/test262/Runner.pm:91
> +$resultsDir = $resultsDir . "/results";

Let's change the results directory name to include test262.
Comment 3 valerie 2018-05-08 07:31:10 PDT
Created attachment 339819 [details]
Patch
Comment 4 Build Bot 2018-05-08 09:10:27 PDT
Comment on attachment 339819 [details]
Patch

Attachment 339819 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7607461

New failing tests:
http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html
Comment 5 Build Bot 2018-05-08 09:10:28 PDT
Created attachment 339823 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 6 Michael Saboff 2018-05-08 10:39:20 PDT
Comment on attachment 339819 [details]
Patch

r=me
Comment 7 WebKit Commit Bot 2018-05-08 11:05:41 PDT
Comment on attachment 339819 [details]
Patch

Rejecting attachment 339819 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 339819, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/Scripts/test262/Runner.pm
Hunk #2 FAILED at 85.
Hunk #6 succeeded at 206 (offset -1 lines).
Hunk #7 succeeded at 903 (offset -1 lines).
1 out of 7 hunks FAILED -- saving rejects to file Tools/Scripts/test262/Runner.pm.rej
patching file .gitignore
patching file ChangeLog

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Michael Saboff']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/7608985
Comment 8 valerie 2018-05-08 12:52:42 PDT
Created attachment 339858 [details]
Patch
Comment 9 valerie 2018-05-08 13:26:47 PDT
Created attachment 339862 [details]
Patch
Comment 10 valerie 2018-05-08 13:28:55 PDT
Created attachment 339864 [details]
Manually created patch for this bug
Comment 11 valerie 2018-05-08 13:30:28 PDT
Created attachment 339865 [details]
Add test262-results dir
Comment 12 valerie 2018-05-08 13:54:31 PDT
Created attachment 339870 [details]
Patch
Comment 13 valerie 2018-05-08 13:59:10 PDT
Created attachment 339872 [details]
patch
Comment 14 Michael Saboff 2018-05-08 14:54:54 PDT
Comment on attachment 339872 [details]
patch

r=me
Comment 15 WebKit Commit Bot 2018-05-08 17:04:16 PDT
Comment on attachment 339872 [details]
patch

Clearing flags on attachment: 339872

Committed r231526: <https://trac.webkit.org/changeset/231526>
Comment 16 WebKit Commit Bot 2018-05-08 17:04:18 PDT
All reviewed patches have been landed.  Closing bug.