Summary: | Use a dark gray for system preview background | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||
Component: | New Bugs | Assignee: | Dean Jackson <dino> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric.carlson, jonlee, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Dean Jackson
2018-05-07 13:46:16 PDT
Created attachment 339748 [details]
Patch
Comment on attachment 339748 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339748&action=review > Source/WebKit/UIProcess/ios/WKSystemPreviewView.mm:64 > + UIColor *backgroundColor = [UIColor colorWithRed:(38. / 255) green:(38. / 255) blue:(38. / 255) alpha:1] not being used? Comment on attachment 339748 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339748&action=review >> Source/WebKit/UIProcess/ios/WKSystemPreviewView.mm:64 >> + UIColor *backgroundColor = [UIColor colorWithRed:(38. / 255) green:(38. / 255) blue:(38. / 255) alpha:1] > > not being used? Ditto. Comment on attachment 339748 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339748&action=review >>> Source/WebKit/UIProcess/ios/WKSystemPreviewView.mm:64 >>> + UIColor *backgroundColor = [UIColor colorWithRed:(38. / 255) green:(38. / 255) blue:(38. / 255) alpha:1] >> >> not being used? > > Ditto. Oh gosh. This patch is very wrong. It will make sense when I fix it. Committed r231454: <https://trac.webkit.org/changeset/231454> |