Bug 185391

Summary: Use a dark gray for system preview background
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, jonlee, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch eric.carlson: review+

Dean Jackson
Reported 2018-05-07 13:46:16 PDT
Use a dark gray for system preview bbackground
Attachments
Patch (1.73 KB, patch)
2018-05-07 13:50 PDT, Dean Jackson 		eric.carlson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-05-07 13:48:06 PDT
<rdar://problem/40035120>
Dean Jackson
Comment 2 2018-05-07 13:50:51 PDT
Created attachment 339748 [details] Patch
Jon Lee
Comment 3 2018-05-07 13:53:25 PDT
Comment on attachment 339748 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339748&action=review > Source/WebKit/UIProcess/ios/WKSystemPreviewView.mm:64 > + UIColor *backgroundColor = [UIColor colorWithRed:(38. / 255) green:(38. / 255) blue:(38. / 255) alpha:1] not being used?
Eric Carlson
Comment 4 2018-05-07 13:55:10 PDT
Comment on attachment 339748 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339748&action=review >> Source/WebKit/UIProcess/ios/WKSystemPreviewView.mm:64 >> + UIColor *backgroundColor = [UIColor colorWithRed:(38. / 255) green:(38. / 255) blue:(38. / 255) alpha:1] > > not being used? Ditto.
Dean Jackson
Comment 5 2018-05-07 13:56:02 PDT
Comment on attachment 339748 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339748&action=review >>> Source/WebKit/UIProcess/ios/WKSystemPreviewView.mm:64 >>> + UIColor *backgroundColor = [UIColor colorWithRed:(38. / 255) green:(38. / 255) blue:(38. / 255) alpha:1] >> >> not being used? > > Ditto. Oh gosh. This patch is very wrong. It will make sense when I fix it.
Dean Jackson
Comment 6 2018-05-07 14:00:30 PDT
Committed r231454: <https://trac.webkit.org/changeset/231454>
Note You need to log in before you can comment on or make changes to this bug.