Bug 185388

Summary: REGRESSION(r211075): Web Inspector throws an exception when inspecting WebViews on iOS 8.4 simulator
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Blaze Burg <bburg>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: bburg, hi, inspector-bugzilla-changes, joepeck
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch joepeck: review+

Blaze Burg
Reported 2018-05-07 12:04:13 PDT
Missing a HeapAgent check.
Attachments
Patch (1.67 KB, patch)
2018-05-07 12:06 PDT, Blaze Burg 		joepeck: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2018-05-07 12:06:22 PDT
Created attachment 339737 [details] Patch
Joseph Pecoraro
Comment 2 2018-05-07 12:08:22 PDT
Comment on attachment 339737 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339737&action=review > Source/WebInspectorUI/UserInterface/Views/LogContentView.js:132 > - if (HeapAgent.gc) > + // COMPATIBILITY (iOS 9): HeapAgent did not exist. > + if (WI.mainTarget.HeapAgent) Normally this is just `if (window.HeapAgent)` I think its a little weird to use `WI.mainTarget`.
Note You need to log in before you can comment on or make changes to this bug.