Bug 185376

Summary: Update MediaSession to use release logging
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: ahmad.saleem792, commit-queue, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Eric Carlson
Reported 2018-05-07 07:02:31 PDT
Update MediaSession to use runtime logging
Attachments
Patch (34.03 KB, patch)
2018-05-07 07:10 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch (34.45 KB, patch)
2018-05-07 08:24 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing (36.37 KB, patch)
2018-05-09 15:36 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-05-07 07:03:27 PDT
<rdar://problem/40022203>
Eric Carlson
Comment 2 2018-05-07 07:10:00 PDT
Created attachment 339716 [details] Patch
Eric Carlson
Comment 3 2018-05-07 08:24:59 PDT
Created attachment 339723 [details] Patch
youenn fablet
Comment 4 2018-05-07 09:19:50 PDT
Comment on attachment 339723 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339723&action=review > Source/WebCore/html/MediaElementSession.cpp:135 > + INFO_LOG(LOGIDENTIFIER, "adding ", restrictionName(restriction)); There might be cases where would want to log even if m_restrictions & restriction is true. Shouldn't we inverse m_restrictions before doing the &?
Eric Carlson
Comment 5 2018-05-09 15:36:11 PDT
Created attachment 340044 [details] Patch for landing
WebKit Commit Bot
Comment 6 2018-05-09 16:02:34 PDT
Comment on attachment 340044 [details] Patch for landing Clearing flags on attachment: 340044 Committed r231604: <https://trac.webkit.org/changeset/231604>
Note You need to log in before you can comment on or make changes to this bug.