Bug 185371

Summary:

[DFG][MIPS] Simplify DFG code by increasing MIPS temporary registers

Product:

WebKit

Reporter:

Yusuke Suzuki <ysuzuki>

Component:

New Bugs

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cgarcia, dominik.infuehr, ews-watchlist, guijemont, keith_miller, mark.lam, mcatanzaro, msaboff, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mark.lam: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews206 for win-future	none

Yusuke Suzuki

Reported 2018-05-06 23:29:12 PDT

[DFG][MIPS] Simplify DFG code by increasing MIPS temporary registers

Attachments
Patch (10.07 KB, patch) 2018-05-06 23:34 PDT, Yusuke Suzuki	mark.lam: review+ ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews206 for win-future (12.81 MB, application/zip) 2018-05-07 04:05 PDT, EWS Watchlist	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Yusuke Suzuki

Comment 1 2018-05-06 23:34:04 PDT

Created attachment 339706 [details] Patch

EWS Watchlist

Comment 2 2018-05-07 04:05:03 PDT

Comment on attachment 339706 [details] Patch Attachment 339706 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7592820 New failing tests: http/tests/preload/onload_event.html

EWS Watchlist

Comment 3 2018-05-07 04:05:14 PDT

Created attachment 339712 [details] Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Yusuke Suzuki

Comment 4 2018-05-07 04:14:31 PDT

(In reply to Build Bot from comment #3) > Created attachment 339712 [details] > Archive of layout-test-results from ews206 for win-future > > The attached test failures were seen while running run-webkit-tests on the > win-ews. > Bot: ews206 Port: win-future Platform: > CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit Unrelated to Windows

Dominik Inführ

Comment 5 2018-05-07 13:02:37 PDT

Thanks for working on this! Not sure if you have access to a MIPS system, so just in case I've built the patch and run all tests successfully on MIPS. Could the expression `#if CPU(X86) && USE(JSVALUE32_64)` be simplified to `#if CPU(X86)`?

Yusuke Suzuki

Comment 6 2018-05-07 17:10:45 PDT

(In reply to Dominik Inführ from comment #5) > Thanks for working on this! Not sure if you have access to a MIPS system, so > just in case I've built the patch and run all tests successfully on MIPS. > > Could the expression `#if CPU(X86) && USE(JSVALUE32_64)` be simplified to > `#if CPU(X86)`? Nice. I don’t have any MIPS machines. I’m happy to hear that it works.

Mark Lam

Comment 7 2018-05-07 17:21:01 PDT

Comment on attachment 339706 [details] Patch LGTM.

Yusuke Suzuki

Comment 8 2018-05-07 18:12:44 PDT

(In reply to Dominik Inführ from comment #5) > Could the expression `#if CPU(X86) && USE(JSVALUE32_64)` be simplified to > `#if CPU(X86)`? Changed. This part depends on the number of registers. So rather than using USE(JSVALUE32_64), using CPU(X86) is better.

Yusuke Suzuki

Comment 9 2018-05-07 18:13:08 PDT

Committed r231472: <https://trac.webkit.org/changeset/231472>

Radar WebKit Bug Importer

Comment 10 2018-05-07 18:15:10 PDT

<rdar://problem/40045024>

Note You need to log in before you can comment on or make changes to this bug.