Bug 185356

Summary: Draw a drop-shadow behind the system preview badge
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch wenson_hsieh: review+

Dean Jackson
Reported 2018-05-05 14:50:26 PDT
Draw a drop-shadow behind the system preview badge
Attachments
Patch (6.59 KB, patch)
2018-05-05 15:02 PDT, Dean Jackson 		wenson_hsieh: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-05-05 14:51:47 PDT
<rdar://problem/40004936>
Dean Jackson
Comment 2 2018-05-05 15:02:00 PDT
Created attachment 339656 [details] Patch
Wenson Hsieh
Comment 3 2018-05-05 15:19:34 PDT
Comment on attachment 339656 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339656&action=review > Source/WebCore/rendering/RenderThemeIOS.mm:1853 > + RetainPtr<CGPathRef> circle = adoptCF(CGPathCreateWithRoundedRect(absoluteBadgeRect, badgeDimension / 2, badgeDimension / 2, nullptr)); Nit - I think we generally auto these.
Dean Jackson
Comment 4 2018-05-05 15:43:16 PDT
Committed r231397: <https://trac.webkit.org/changeset/231397>
Darin Adler
Comment 5 2018-05-06 17:06:40 PDT
Comment on attachment 339656 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339656&action=review >> Source/WebCore/rendering/RenderThemeIOS.mm:1853 >> + RetainPtr<CGPathRef> circle = adoptCF(CGPathCreateWithRoundedRect(absoluteBadgeRect, badgeDimension / 2, badgeDimension / 2, nullptr)); > > Nit - I think we generally auto these. I often work with both of you on WebKit and I endorse this message.
Note You need to log in before you can comment on or make changes to this bug.