| Summary: | [Extra zoom mode] Google search results are excessively zoomed in | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||||||||||||
| Component: | WebKit Misc. | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||
| Severity: | Normal | CC: | bdakin, cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, fred.wang, gyuyoung.kim, japhet, kangil.han, simon.fraser, thorton, timothy, webkit-bug-importer | ||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
|
Description
Wenson Hsieh
2018-05-05 00:35:51 PDT
Created attachment 339660 [details]
Patch
Comment on attachment 339660 [details] Patch Attachment 339660 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7581212 New failing tests: http/tests/security/canvas-remote-read-remote-video-localhost.html Created attachment 339665 [details]
Archive of layout-test-results from ews200 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 339665 [details]
Archive of layout-test-results from ews200 for win-future
Test failure seems unrelated.
Created attachment 339913 [details]
Patch
Created attachment 339915 [details]
Rebase on trunk
Created attachment 339919 [details]
Actually rebase on trunk
Comment on attachment 339919 [details]
Actually rebase on trunk
This is no longer the approach we’re planning to take.
Created attachment 340340 [details]
Patch
Created attachment 340349 [details]
Try to fix non-internal builds
Comment on attachment 340349 [details] Try to fix non-internal builds Clearing flags on attachment: 340349 Committed r231779: <https://trac.webkit.org/changeset/231779> All reviewed patches have been landed. Closing bug. Comment on attachment 340349 [details] Try to fix non-internal builds View in context: https://bugs.webkit.org/attachment.cgi?id=340349&action=review > Source/WebCore/page/WindowFeatures.h:63 > +OptionSet<DisabledAdaptations> parseDisabledAdaptations(const String&); It looks WindowFeatures.cpp|h needed the <wtf/OptionSet.h> header. At least I got build error with rotating unified source. I just landed a fix for that. (In reply to Frédéric Wang (:fredw) from comment #14) > Comment on attachment 340349 [details] > Try to fix non-internal builds > > View in context: > https://bugs.webkit.org/attachment.cgi?id=340349&action=review > > > Source/WebCore/page/WindowFeatures.h:63 > > +OptionSet<DisabledAdaptations> parseDisabledAdaptations(const String&); > > It looks WindowFeatures.cpp|h needed the <wtf/OptionSet.h> header. At least > I got build error with rotating unified source. I just landed a fix for that. Sorry — thanks for the fix! |