Bug 185334

Summary: Shift to a lower-level framework for simplifying URLs
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mitz, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Tim Horton
Reported 2018-05-04 16:16:30 PDT
Shift to a lower-level framework for simplifying URLs
Attachments
Patch (21.98 KB, patch)
2018-05-04 16:17 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (22.06 KB, patch)
2018-05-04 16:38 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2018-05-04 16:17:20 PDT
Created attachment 339606 [details] Patch
mitz
Comment 2 2018-05-04 16:23:12 PDT
Comment on attachment 339606 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339606&action=review > Source/WebCore/platform/mac/DragImageMac.mm:-47 > -#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300 Not clear why we’d want to try to use Link Presentation prior to macOS 10.13.
Tim Horton
Comment 3 2018-05-04 16:32:54 PDT
Comment on attachment 339606 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339606&action=review >> Source/WebCore/platform/mac/DragImageMac.mm:-47 >> -#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300 > > Not clear why we’d want to try to use Link Presentation prior to macOS 10.13. Not clear why I picked 10.13 originally, LinkPresentation is available in 10.12 and the method we use in 10.12.3. I don't think we build back that far anymore (at least, as far as I can tell, we always build with the biggest point update, and only back to 10.12.x).
Tim Horton
Comment 4 2018-05-04 16:38:48 PDT
Created attachment 339612 [details] Patch
WebKit Commit Bot
Comment 5 2018-05-04 17:16:23 PDT
Comment on attachment 339612 [details] Patch Clearing flags on attachment: 339612 Committed r231393: <https://trac.webkit.org/changeset/231393>
WebKit Commit Bot
Comment 6 2018-05-04 17:16:25 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-05-04 17:17:25 PDT
<rdar://problem/39994948>
Note You need to log in before you can comment on or make changes to this bug.