| Summary: | Web Inspector: console should show an icon for console.info() messages | ||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||||||||||||||||||||||||
| Component: | Web Inspector | Assignee: | Jon Davis <jond> | ||||||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||||||
| Severity: | Normal | CC: | agomez, buildbot, burg, commit-queue, darin, dsam2912, eric, graouts, jberlin, joepeck, josephburnett79, me, paulirish, rniwa, timothy, webkit-bug-importer, webkit.review.bot | ||||||||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||||||||||||||
| Hardware: | All | ||||||||||||||||||||||||||||
| OS: | All | ||||||||||||||||||||||||||||
| Bug Depends on: | 144488 | ||||||||||||||||||||||||||||
| Bug Blocks: | 144461 | ||||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||||
|
Description
Adam Roben (:aroben)
2008-04-16 08:44:11 PDT
Created attachment 20584 [details]
Screenshot of Firebug's console.info and console.log output
I am tempted to say use our tip balloon icon. Created attachment 53161 [details]
Show the tip icon by console.info entries
Attachment 53161 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/ChangeLog:6: Line contains tab character. [whitespace/tab] [5]
Total errors found: 1 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 53450 [details]
Fixed style problem with previous patch.
Created attachment 54222 [details]
Screenshot of console.info icon
Comment on attachment 53450 [details]
Fixed style problem with previous patch.
Tab in the ChangeLog will prevent the cq from being able to land this for you.
There's no tab in the most recent patch, 4/5/2010. I saw the failed style and fixed it already. (In reply to comment #7) > (From update of attachment 53450 [details]) > Tab in the ChangeLog will prevent the cq from being able to land this for you. On IRC pfeldman mentioned that the only reason he will not r+ the patch is that he isn't a fan of the icon. He thinks that it should be in line with the warningIcon.png and errorIcon.png, using the same exclamation style + blue circle as a background (to be more aligned with firebug). Joseph would need the image source for these. pfeldman suggested that Tim might land the image sources under front-end/ImageSources. Tim, Is there a way to export your imagery to gimp and open source it? Did this get landed? Assuming it did. It was not landed. See comment #9. We're still waiting on comment from Tim Hatcher? is that correct? Correct. With the image from Tim Hatcher, the patch should be good to go. @xenon: Ping? Created attachment 139985 [details]
sample for console info icon
If its ok with Joseph and Pavel, and console-info icon looks ok, i can upload a patch for it.
(In reply to comment #16) > Created an attachment (id=139985) [details] > sample for console info icon > > If its ok with Joseph and Pavel, and console-info icon looks ok, i can upload a patch for it. I like the image from https://bugs.webkit.org/attachment.cgi?id=54222 more. I assume this was landed? (In reply to comment #18) > I assume this was landed? Nope, not yet. Sam, can you update the patch? Someone should pick this one up and do it. Assigning this to Jon Davis, he has an SVG icon for this. Created attachment 248741 [details]
Adds Debug, Info and Log SVG icons.
Comment on attachment 248741 [details]
Adds Debug, Info and Log SVG icons.
Nice!
Comment on attachment 248741 [details] Adds Debug, Info and Log SVG icons. View in context: https://bugs.webkit.org/attachment.cgi?id=248741&action=review > Source/WebInspectorUI/UserInterface/Images/Info.svg:1 > +<?xml version="1.0" encoding="utf-8"?> Since console.info is just an alias of console.debug right now. Should we separate the two? Otherwise this image won't get used. Comment on attachment 248741 [details]
Adds Debug, Info and Log SVG icons.
Oh, I forgot about that.
(In reply to comment #26) > Comment on attachment 248741 [details] > Adds Debug, Info and Log SVN icons. > > Oh, I forgot about that. Jon, if you wanted to look at this (C++ side) you'd be looking at: Source/JavaScriptCore/runtime/ConsolePrototype.cpp Source/JavaScriptCore/runtime/ConsoleTypes.h Or pass this my way. Created attachment 251997 [details]
Patch
Adds new icons and separates console.info from console.log.
Comment on attachment 251997 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251997&action=review The rest of this patch looks good to me! > Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js:53 > + case WebInspector.ConsoleMessage.MessageLevel.Info: You are missing a check for "case WebInspector.ConsoleMessage.MessageLevel.Info" in LogContentView.js ~ line 670. LogContentView.prototype._filterMessageElements has a switch on the message level, you should treat "info" as a filter like Debug/Log. Created attachment 252004 [details]
Patch
Adds missing switch for console message filters, and missing localized string entry.
Comment on attachment 251997 [details] Patch Attachment 251997 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5396782225817600 New failing tests: inspector-protocol/console/console-message.html Created attachment 252007 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Comment on attachment 251997 [details] Patch Attachment 251997 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6278785435435008 New failing tests: inspector-protocol/console/console-message.html Created attachment 252010 [details]
Archive of layout-test-results from ews101 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5
Created attachment 252011 [details]
Patch
Appeasing the bots with updated expected output.
Comment on attachment 252011 [details]
Patch
You will need to post a new version that is rebased since this one does not apply to TOT anymore. Otherwise looks good.
Created attachment 252061 [details]
Patch
Rebased patch.
|