Bug 18530

Summary:

Web Inspector: console should show an icon for console.info() messages

Product:

WebKit

Reporter:

Adam Roben (:aroben) <aroben>

Component:

Web Inspector

Assignee:

Jon Davis <jond>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

agomez, buildbot, burg, commit-queue, darin, dsam2912, eric, graouts, jberlin, joepeck, josephburnett79, me, paulirish, rniwa, timothy, webkit-bug-importer, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

144488

Bug Blocks:

144461

Attachments:

Description	Flags
Screenshot of Firebug's console.info and console.log output	none
Show the tip icon by console.info entries	none
Fixed style problem with previous patch.	none
Screenshot of console.info icon	none
sample for console info icon	none
Adds Debug, Info and Log SVG icons.	timothy: review+
Patch	timothy: review+, joepeck: commit-queue-
Patch	none
Archive of layout-test-results from ews105 for mac-mavericks-wk2	none
Archive of layout-test-results from ews101 for mac-mavericks	none
Patch	timothy: review+, timothy: commit-queue-
Patch	none

Adam Roben (:aroben)

Reported 2008-04-16 08:44:11 PDT

The Inspector's Console should visually distinguish console.info from console.log. In Firebug, console.info has an "information" icon next to it (a blue circle with a white lowercase "i" inside it).

Attachments
Screenshot of Firebug's console.info and console.log output (6.94 KB, image/png) 2008-04-16 08:45 PDT, Adam Roben (:aroben)	no flags	Details
Show the tip icon by console.info entries (4.34 KB, patch) 2010-04-12 04:01 PDT, Joseph Burnett	no flags	Details Formatted Diff Diff
Fixed style problem with previous patch. (4.35 KB, patch) 2010-04-15 10:54 PDT, Joseph Burnett	no flags	Details Formatted Diff Diff
Screenshot of console.info icon (4.06 KB, image/png) 2010-04-24 12:20 PDT, Joseph Burnett	no flags	Details
sample for console info icon (527 bytes, image/png) 2012-05-03 05:08 PDT, sam	no flags	Details
Adds Debug, Info and Log SVG icons. (5.83 KB, patch) 2015-03-16 12:15 PDT, Jon Davis	timothy: review+	Details Formatted Diff Diff
Patch (17.33 KB, patch) 2015-04-29 15:45 PDT, Jon Davis	timothy: review+ joepeck: commit-queue-	Details Formatted Diff Diff
Patch (18.34 KB, patch) 2015-04-29 16:32 PDT, Jon Davis	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews105 for mac-mavericks-wk2 (727.75 KB, application/zip) 2015-04-29 16:39 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews101 for mac-mavericks (524.42 KB, application/zip) 2015-04-29 16:53 PDT, Build Bot	no flags	Details
Patch (19.59 KB, patch) 2015-04-29 17:09 PDT, Jon Davis	timothy: review+ timothy: commit-queue-	Details Formatted Diff Diff
Patch (19.54 KB, patch) 2015-04-30 09:06 PDT, Jon Davis	no flags	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

Adam Roben (:aroben)

Comment 1 2008-04-16 08:45:45 PDT

Created attachment 20584 [details] Screenshot of Firebug's console.info and console.log output

Timothy Hatcher

Comment 2 2008-04-16 09:20:07 PDT

I am tempted to say use our tip balloon icon.

Joseph Burnett

Comment 3 2010-04-12 04:01:31 PDT

Created attachment 53161 [details] Show the tip icon by console.info entries

WebKit Review Bot

Comment 4 2010-04-12 04:05:14 PDT

Attachment 53161 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.

Joseph Burnett

Comment 5 2010-04-15 10:54:53 PDT

Created attachment 53450 [details] Fixed style problem with previous patch.

Joseph Burnett

Comment 6 2010-04-24 12:20:35 PDT

Created attachment 54222 [details] Screenshot of console.info icon

Eric Seidel (no email)

Comment 7 2010-05-07 23:22:38 PDT

Comment on attachment 53450 [details] Fixed style problem with previous patch. Tab in the ChangeLog will prevent the cq from being able to land this for you.

Joseph Burnett

Comment 8 2010-05-08 07:55:26 PDT

There's no tab in the most recent patch, 4/5/2010. I saw the failed style and fixed it already. (In reply to comment #7) > (From update of attachment 53450 [details]) > Tab in the ChangeLog will prevent the cq from being able to land this for you.

Jessie Berlin

Comment 9 2010-05-13 10:42:24 PDT

On IRC pfeldman mentioned that the only reason he will not r+ the patch is that he isn't a fan of the icon. He thinks that it should be in line with the warningIcon.png and errorIcon.png, using the same exclamation style + blue circle as a background (to be more aligned with firebug). Joseph would need the image source for these. pfeldman suggested that Tim might land the image sources under front-end/ImageSources. Tim, Is there a way to export your imagery to gimp and open source it?

Eric Seidel (no email)

Comment 10 2010-09-02 13:52:31 PDT

Did this get landed?

Eric Seidel (no email)

Comment 11 2010-09-15 00:17:57 PDT

Assuming it did.

Jessie Berlin

Comment 12 2010-09-15 05:50:05 PDT

It was not landed. See comment #9.

Eric Seidel (no email)

Comment 13 2010-10-14 11:36:52 PDT

We're still waiting on comment from Tim Hatcher? is that correct?

Joseph Burnett

Comment 14 2010-10-17 20:26:16 PDT

Correct. With the image from Tim Hatcher, the patch should be good to go.

Eric Seidel (no email)

Comment 15 2010-12-20 23:00:14 PST

@xenon: Ping?

sam

Comment 16 2012-05-03 05:08:58 PDT

Created attachment 139985 [details] sample for console info icon If its ok with Joseph and Pavel, and console-info icon looks ok, i can upload a patch for it.

Pavel Feldman

Comment 17 2012-05-03 05:11:52 PDT

(In reply to comment #16) > Created an attachment (id=139985) [details] > sample for console info icon > > If its ok with Joseph and Pavel, and console-info icon looks ok, i can upload a patch for it. I like the image from https://bugs.webkit.org/attachment.cgi?id=54222 more.

Eric Seidel (no email)

Comment 18 2013-01-04 00:49:42 PST

I assume this was landed?

Paul Irish

Comment 19 2013-01-04 16:47:41 PST

(In reply to comment #18) > I assume this was landed? Nope, not yet. Sam, can you update the patch?

Darin Adler

Comment 20 2013-05-08 09:08:00 PDT

Someone should pick this one up and do it.

Radar WebKit Bug Importer

Comment 21 2014-01-12 14:59:01 PST

<rdar://problem/15801362>

Timothy Hatcher

Comment 22 2015-03-01 18:22:51 PST

Assigning this to Jon Davis, he has an SVG icon for this.

Jon Davis

Comment 23 2015-03-16 12:15:26 PDT

Created attachment 248741 [details] Adds Debug, Info and Log SVG icons.

Timothy Hatcher

Comment 24 2015-03-16 14:19:27 PDT

Comment on attachment 248741 [details] Adds Debug, Info and Log SVG icons. Nice!

Joseph Pecoraro

Comment 25 2015-03-16 14:21:15 PDT

Comment on attachment 248741 [details] Adds Debug, Info and Log SVG icons. View in context: https://bugs.webkit.org/attachment.cgi?id=248741&action=review > Source/WebInspectorUI/UserInterface/Images/Info.svg:1 > +<?xml version="1.0" encoding="utf-8"?> Since console.info is just an alias of console.debug right now. Should we separate the two? Otherwise this image won't get used.

Timothy Hatcher

Comment 26 2015-03-16 14:35:07 PDT

Comment on attachment 248741 [details] Adds Debug, Info and Log SVG icons. Oh, I forgot about that.

Joseph Pecoraro

Comment 27 2015-03-16 14:38:38 PDT

(In reply to comment #26) > Comment on attachment 248741 [details] > Adds Debug, Info and Log SVN icons. > > Oh, I forgot about that. Jon, if you wanted to look at this (C++ side) you'd be looking at: Source/JavaScriptCore/runtime/ConsolePrototype.cpp Source/JavaScriptCore/runtime/ConsoleTypes.h Or pass this my way.

Jon Davis

Comment 28 2015-04-29 15:45:11 PDT

Created attachment 251997 [details] Patch Adds new icons and separates console.info from console.log.

Joseph Pecoraro

Comment 29 2015-04-29 15:54:41 PDT

Comment on attachment 251997 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251997&action=review The rest of this patch looks good to me! > Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js:53 > + case WebInspector.ConsoleMessage.MessageLevel.Info: You are missing a check for "case WebInspector.ConsoleMessage.MessageLevel.Info" in LogContentView.js ~ line 670. LogContentView.prototype._filterMessageElements has a switch on the message level, you should treat "info" as a filter like Debug/Log.

Jon Davis

Comment 30 2015-04-29 16:32:30 PDT

Created attachment 252004 [details] Patch Adds missing switch for console message filters, and missing localized string entry.

Build Bot

Comment 31 2015-04-29 16:39:00 PDT

Comment on attachment 251997 [details] Patch Attachment 251997 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5396782225817600 New failing tests: inspector-protocol/console/console-message.html

Build Bot

Comment 32 2015-04-29 16:39:06 PDT

Created attachment 252007 [details] Archive of layout-test-results from ews105 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Build Bot

Comment 33 2015-04-29 16:53:39 PDT

Comment on attachment 251997 [details] Patch Attachment 251997 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6278785435435008 New failing tests: inspector-protocol/console/console-message.html

Build Bot

Comment 34 2015-04-29 16:53:44 PDT

Created attachment 252010 [details] Archive of layout-test-results from ews101 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5

Jon Davis

Comment 35 2015-04-29 17:09:09 PDT

Created attachment 252011 [details] Patch Appeasing the bots with updated expected output.

Timothy Hatcher

Comment 36 2015-04-30 01:15:43 PDT

Comment on attachment 252011 [details] Patch You will need to post a new version that is rebased since this one does not apply to TOT anymore. Otherwise looks good.

Jon Davis

Comment 37 2015-04-30 09:06:16 PDT

Created attachment 252061 [details] Patch Rebased patch.

Jon Davis

Comment 38 2015-04-30 18:12:35 PDT

https://trac.webkit.org/changeset/183659

Note You need to log in before you can comment on or make changes to this bug.