Bug 185292

Summary: Remove std::random_shuffle
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, darin, ews-watchlist, fpizlo, keith_miller, mark.lam, msaboff, rniwa, saam, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 185293    
Attachments:
Description Flags
Patch darin: review+

Yusuke Suzuki
Reported 2018-05-03 21:46:25 PDT
Remove std::random_shuffle
Attachments
Patch (2.77 KB, patch)
2018-05-03 21:47 PDT, Yusuke Suzuki 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-05-03 21:47:10 PDT
Created attachment 339520 [details] Patch
Filip Pizlo
Comment 2 2018-05-03 22:19:21 PDT
Comment on attachment 339520 [details] Patch Can we instead have a WeakRandon rwference passed to BinarySwitch? Maybe users of BinarySwitch can keep a WeakRandom around longer.
Darin Adler
Comment 3 2018-05-03 22:22:58 PDT
(In reply to Filip Pizlo from comment #2) > Can we instead have a WeakRandon rwference passed to BinarySwitch? Maybe > users of BinarySwitch can keep a WeakRandom around longer. Seems OK, but this is not changing here, so seems orthogonal.
Yusuke Suzuki
Comment 4 2018-05-03 22:31:13 PDT
(In reply to Filip Pizlo from comment #2) > Comment on attachment 339520 [details] > Patch > > Can we instead have a WeakRandon rwference passed to BinarySwitch? Maybe > users of BinarySwitch can keep a WeakRandom around longer. OK, I'll do this that in a separate patch. This patch removes std::random_shuffle, this is required b/c C++17 removes this function, and actually MSVC w/ C++17 flag does not have this function :)
Yusuke Suzuki
Comment 5 2018-05-03 22:32:46 PDT
Committed r231347: <https://trac.webkit.org/changeset/231347>
Radar WebKit Bug Importer
Comment 6 2018-05-03 22:33:27 PDT
<rdar://problem/39967119>
Note You need to log in before you can comment on or make changes to this bug.