Bug 185290

Summary: Rename DocumentOrderedMap to TreeScopeOrderedMap
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, gyuyoung.kim, kangil.han, koivisto, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Cleanup
none
Patch for landing none

Ryosuke Niwa
Reported 2018-05-03 20:48:10 PDT
It's a mistake to use DocumentOrderedMap in Document. Rename the class to make this clear.
Attachments
Cleanup (11.61 KB, patch)
2018-05-03 20:52 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Patch for landing (45.49 KB, patch)
2018-05-04 14:25 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2018-05-03 20:52:38 PDT
Created attachment 339517 [details] Cleanup
Ryosuke Niwa
Comment 2 2018-05-04 14:25:41 PDT
Created attachment 339595 [details] Patch for landing
Ryosuke Niwa
Comment 3 2018-05-04 14:25:59 PDT
Comment on attachment 339595 [details] Patch for landing Wait for EWS.
EWS Watchlist
Comment 4 2018-05-04 14:27:56 PDT
Attachment 339595 [details] did not pass style-queue: ERROR: Source/WebCore/dom/TreeScopeOrderedMap.cpp:53: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] ERROR: Source/WebCore/dom/TreeScopeOrderedMap.cpp:63: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] ERROR: Source/WebCore/dom/TreeScopeOrderedMap.cpp:84: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] ERROR: Source/WebCore/dom/TreeScopeOrderedMap.cpp:111: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] ERROR: Source/WebCore/dom/TreeScopeOrderedMap.cpp:121: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] Total errors found: 5 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ryosuke Niwa
Comment 5 2018-05-04 16:52:46 PDT
Committed r231390: <https://trac.webkit.org/changeset/231390>
Radar WebKit Bug Importer
Comment 6 2018-05-04 16:53:16 PDT
<rdar://problem/39994362>
Note You need to log in before you can comment on or make changes to this bug.