Bug 185281

Summary: OSR entry pruning of Program Bytecodes doesn't take into account try/catch
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Updated Patch saam: review+

Michael Saboff
Reported 2018-05-03 17:11:37 PDT
In the baseline, we have an optimization where we prune unreachable code beginning from the instruction we OSR entry to. This pruning needs to take into account the reachability from local catch statements.
Attachments
Patch (4.09 KB, patch)
2018-05-03 17:24 PDT, Michael Saboff 		no flags
DetailsFormatted DiffDiff
Updated Patch (4.01 KB, patch)
2018-05-03 17:48 PDT, Michael Saboff 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2018-05-03 17:12:08 PDT
<rdar://problem/39456551>
Michael Saboff
Comment 2 2018-05-03 17:24:05 PDT
Created attachment 339494 [details] Patch
Michael Saboff
Comment 3 2018-05-03 17:48:46 PDT
Created attachment 339497 [details] Updated Patch
Saam Barati
Comment 4 2018-05-03 17:50:29 PDT
Comment on attachment 339497 [details] Updated Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339497&action=review r=me > Source/JavaScriptCore/jit/JIT.cpp:203 > + please delete. > Source/JavaScriptCore/jit/JIT.cpp:228 > + for (unsigned bytecodeOffset = block->leaderOffset(); bytecodeOffset < block->leaderOffset() + block->totalLength();) { Can we skip this loop if the program has no catch handlers?
Michael Saboff
Comment 5 2018-05-03 18:00:50 PDT
(In reply to Saam Barati from comment #4) > Comment on attachment 339497 [details] > Updated Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=339497&action=review > > r=me > > > Source/JavaScriptCore/jit/JIT.cpp:203 > > + > > please delete. > > > Source/JavaScriptCore/jit/JIT.cpp:228 > > + for (unsigned bytecodeOffset = block->leaderOffset(); bytecodeOffset < block->leaderOffset() + block->totalLength();) { > > Can we skip this loop if the program has no catch handlers? I'll take care of those changes locally before landing.
Michael Saboff
Comment 6 2018-05-03 18:11:49 PDT
Committed r231343: <https://trac.webkit.org/changeset/231343>
Note You need to log in before you can comment on or make changes to this bug.