Bug 185267

Summary: PeerConnection should have its connectionState closed even if doing gathering
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, eric.carlson, ews-watchlist, ryanhaddad, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews115 for mac-sierra none

youenn fablet
Reported 2018-05-03 14:34:27 PDT
PeerConnection should have its connectionState closed even if doing gathering
Attachments
Patch (6.34 KB, patch)
2018-05-03 14:43 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews115 for mac-sierra (3.28 MB, application/zip)
2018-05-04 00:42 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2018-05-03 14:43:20 PDT
Created attachment 339469 [details] Patch
EWS Watchlist
Comment 2 2018-05-04 00:42:04 PDT
Comment on attachment 339469 [details] Patch Attachment 339469 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/7561336 New failing tests: imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_menuitem-element.html
EWS Watchlist
Comment 3 2018-05-04 00:42:05 PDT
Created attachment 339525 [details] Archive of layout-test-results from ews115 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-sierra Platform: Mac OS X 10.12.6
WebKit Commit Bot
Comment 4 2018-05-04 08:18:40 PDT
Comment on attachment 339469 [details] Patch Clearing flags on attachment: 339469 Committed r231352: <https://trac.webkit.org/changeset/231352>
WebKit Commit Bot
Comment 5 2018-05-04 08:18:41 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-05-04 08:19:24 PDT
<rdar://problem/39976629>
Ryan Haddad
Comment 7 2018-05-04 14:31:58 PDT
The test added with this change is a flaky timeout on iOS and macOS Release WK2 bots: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=webrtc%2FaddICECandidate-closed.html
youenn fablet
Comment 8 2018-05-04 16:54:49 PDT
Thanks Ryan, I will fix the test.
Note You need to log in before you can comment on or make changes to this bug.