| Summary: | cleanup modules usage for the Test262-Runner | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Leo Balter <leo> | ||||||||||
| Component: | JavaScriptCore | Assignee: | Leo Balter <leo> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | commit-queue, msaboff, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Leo Balter
2018-05-03 13:30:28 PDT
Created attachment 339450 [details]
Patch
Looks like this patch needs to be rebased. Created attachment 339452 [details]
Patch
Yes, I just rebased it. Thanks! I just found another block bug in the process where the $configFile was being set after the CLI processing. It's being fixed in a follow up patch here. Created attachment 339455 [details]
Patch
Comment on attachment 339455 [details]
Patch
r=me
Created attachment 339457 [details]
Patch
we found the call processCLI is too fragile. so I moved it next to the main() call. Thanks for patience during the extra noise Comment on attachment 339457 [details]
Patch
r=me
Comment on attachment 339457 [details] Patch Clearing flags on attachment: 339457 Committed r231328: <https://trac.webkit.org/changeset/231328> All reviewed patches have been landed. Closing bug. |