Bug 185251

Summary: Ads in NYTimes app are shifted downwards by the scroll view's top content inset
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebKit Misc.Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bdakin, benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Fix OpenSource iOS build
thorton: review+
Patch for landing none

Wenson Hsieh
Reported 2018-05-03 07:56:34 PDT
<rdar://problem/39062357>
Attachments
Patch (3.59 KB, patch)
2018-05-03 09:12 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Fix OpenSource iOS build (5.10 KB, patch)
2018-05-03 12:07 PDT, Wenson Hsieh 		thorton: review+
DetailsFormatted DiffDiff
Patch for landing (5.10 KB, patch)
2018-05-03 12:38 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2018-05-03 09:12:30 PDT
Created attachment 339412 [details] Patch
Wenson Hsieh
Comment 2 2018-05-03 12:07:17 PDT
Created attachment 339435 [details] Fix OpenSource iOS build
Tim Horton
Comment 3 2018-05-03 12:25:40 PDT
Comment on attachment 339435 [details] Fix OpenSource iOS build View in context: https://bugs.webkit.org/attachment.cgi?id=339435&action=review > Source/WebKit/UIProcess/Cocoa/VersionChecks.h:41 > + FirstWhereScrollViewContentInsetsAreNotObscuringInsets = DYLD_IOS_VERSION_12_0 Probably get that trailing comma in there.
Wenson Hsieh
Comment 4 2018-05-03 12:37:01 PDT
Comment on attachment 339435 [details] Fix OpenSource iOS build View in context: https://bugs.webkit.org/attachment.cgi?id=339435&action=review >> Source/WebKit/UIProcess/Cocoa/VersionChecks.h:41 >> + FirstWhereScrollViewContentInsetsAreNotObscuringInsets = DYLD_IOS_VERSION_12_0 > > Probably get that trailing comma in there. Sounds good
Wenson Hsieh
Comment 5 2018-05-03 12:38:16 PDT
Created attachment 339443 [details] Patch for landing
WebKit Commit Bot
Comment 6 2018-05-03 13:16:21 PDT
Comment on attachment 339443 [details] Patch for landing Clearing flags on attachment: 339443 Committed r231322: <https://trac.webkit.org/changeset/231322>
Note You need to log in before you can comment on or make changes to this bug.