Bug 185251 - Ads in NYTimes app are shifted downwards by the scroll view's top content inset
Summary: Ads in NYTimes app are shifted downwards by the scroll view's top content inset
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-03 07:56 PDT by Wenson Hsieh
Modified: 2018-05-14 13:02 PDT (History)
11 users (show)

See Also:

Attachments
Patch (3.59 KB, patch)
2018-05-03 09:12 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Fix OpenSource iOS build (5.10 KB, patch)
2018-05-03 12:07 PDT, Wenson Hsieh 		thorton: review+
Details | Formatted Diff | Diff
Patch for landing (5.10 KB, patch)
2018-05-03 12:38 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2018-05-03 07:56:34 PDT 
<rdar://problem/39062357>
Comment 1 Wenson Hsieh 2018-05-03 09:12:30 PDT 
Created attachment 339412 [details]
Patch
Comment 2 Wenson Hsieh 2018-05-03 12:07:17 PDT 
Created attachment 339435 [details]
Fix OpenSource iOS build
Comment 3 Tim Horton 2018-05-03 12:25:40 PDT 
Comment on attachment 339435 [details]
Fix OpenSource iOS build

View in context: https://bugs.webkit.org/attachment.cgi?id=339435&action=review

> Source/WebKit/UIProcess/Cocoa/VersionChecks.h:41
> +    FirstWhereScrollViewContentInsetsAreNotObscuringInsets = DYLD_IOS_VERSION_12_0

Probably get that trailing comma in there.
Comment 4 Wenson Hsieh 2018-05-03 12:37:01 PDT 
Comment on attachment 339435 [details]
Fix OpenSource iOS build

View in context: https://bugs.webkit.org/attachment.cgi?id=339435&action=review

>> Source/WebKit/UIProcess/Cocoa/VersionChecks.h:41
>> +    FirstWhereScrollViewContentInsetsAreNotObscuringInsets = DYLD_IOS_VERSION_12_0
> 
> Probably get that trailing comma in there.

Sounds good
Comment 5 Wenson Hsieh 2018-05-03 12:38:16 PDT 
Created attachment 339443 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2018-05-03 13:16:21 PDT 
Comment on attachment 339443 [details]
Patch for landing

Clearing flags on attachment: 339443

Committed r231322: <https://trac.webkit.org/changeset/231322>