Bug 185241

Summary: REGRESSION (r231014): Entitlements are not applied to XPC services on macOS
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jer.noble, mitz, saam, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Tim Horton
Reported 2018-05-03 01:00:54 PDT
REGRESSION (r231014): Entitlements are not applied to XPC services on macOS
Attachments
Patch (3.67 KB, patch)
2018-05-03 01:01 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (3.69 KB, patch)
2018-05-03 01:02 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2018-05-03 01:01:07 PDT
Created attachment 339397 [details] Patch
Tim Horton
Comment 2 2018-05-03 01:02:09 PDT
Created attachment 339398 [details] Patch
WebKit Commit Bot
Comment 3 2018-05-03 01:50:15 PDT
Comment on attachment 339398 [details] Patch Clearing flags on attachment: 339398 Committed r231299: <https://trac.webkit.org/changeset/231299>
WebKit Commit Bot
Comment 4 2018-05-03 01:50:16 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-05-03 01:51:30 PDT
<rdar://problem/39935564>
mitz
Comment 6 2018-05-08 10:11:19 PDT
(In reply to WebKit Commit Bot from comment #3) > Comment on attachment 339398 [details] > Patch > > Clearing flags on attachment: 339398 > > Committed r231299: <https://trac.webkit.org/changeset/231299> After this change, the Development service isn’t getting signed with entitlements when building for macOS.
mitz
Comment 7 2018-05-08 10:13:12 PDT
(In reply to mitz from comment #6) > (In reply to WebKit Commit Bot from comment #3) > > Comment on attachment 339398 [details] > > Patch > > > > Clearing flags on attachment: 339398 > > > > Committed r231299: <https://trac.webkit.org/changeset/231299> > > After this change, the Development service isn’t getting signed with > entitlements when building for macOS. The be fair, maybe that was also a problem before this change and after r231014, but in any case, this change didn’t fix the Development service.
mitz
Comment 8 2018-05-08 10:25:45 PDT
Filed bug 185429.
mitz
Comment 9 2018-05-08 10:29:02 PDT
*** Bug 185429 has been marked as a duplicate of this bug. ***
mitz
Comment 10 2018-05-08 10:29:23 PDT
I was very confused and this bug fixed what I thought it had broken.
Note You need to log in before you can comment on or make changes to this bug.