Bug 185230

Summary:

Use IOSurfaces for CoreImage operations where possible

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

New Bugs

Assignee:

Dean Jackson <dino>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, jonlee, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	jonlee: review+

Description Dean Jackson 2018-05-02 17:41:27 PDT

Use IOSurfaces for CoreImage operations where possible

Comment 1 Radar WebKit Bug Importer 2018-05-02 17:41:56 PDT

<rdar://problem/39926929>

Comment 2 Dean Jackson 2018-05-02 17:45:29 PDT

Created attachment 339371 [details]
Patch

Comment 3 Jon Lee 2018-05-04 11:44:58 PDT

Comment on attachment 339371 [details]
Patch

A new patch will be uploaded to address some offline comments.

Comment 4 Dean Jackson 2018-05-04 16:49:09 PDT

Created attachment 339613 [details]
Patch

Comment 5 EWS Watchlist 2018-05-04 16:50:32 PDT

Attachment 339613 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderThemeIOS.h:34:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 6 Dean Jackson 2018-05-04 16:54:35 PDT

oops already fixed include order

Comment 7 Dean Jackson 2018-05-04 16:59:10 PDT

Created attachment 339614 [details]
Patch

Comment 8 Dean Jackson 2018-05-04 17:27:11 PDT

Committed r231394: <https://trac.webkit.org/changeset/231394>