Bug 185227

Summary: Remove superfluous check for a null attribute value check in Element::removeAttributeInternal
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cmarcelo, dbates, esprehn+autocc, ews-watchlist, kangil.han, koivisto, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Removes the code cdumez: review+

Ryosuke Niwa
Reported 2018-05-02 16:47:37 PDT
Element::removeAttributeInternal has a check for valueBeingRemoved.isNull() before calling willModifyAttribute. But this is impossible because attribute value is always empty string or a string of at least length 1.
Attachments
Removes the code (1.38 KB, patch)
2018-05-02 16:59 PDT, Ryosuke Niwa 		cdumez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2018-05-02 16:59:17 PDT
Created attachment 339365 [details] Removes the code
Ryosuke Niwa
Comment 2 2018-05-02 20:40:31 PDT
Committed r231294: <https://trac.webkit.org/changeset/231294>
Radar WebKit Bug Importer
Comment 3 2018-05-02 20:41:25 PDT
<rdar://problem/39930646>
Note You need to log in before you can comment on or make changes to this bug.