Bug 185226

Summary: Remove the prototype caching for get_by_id in the LLInt
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED WONTFIX    
Severity: Normal CC: commit-queue, ews-watchlist, hyungseok.han, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 185564    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Keith Miller
Reported 2018-05-02 16:03:44 PDT
Remove the prototype caching for get_by_id in the LLInt
Attachments
Patch (34.26 KB, patch)
2018-05-02 16:10 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (34.90 KB, patch)
2018-05-03 10:28 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2018-05-02 16:10:52 PDT
Created attachment 339363 [details] Patch
Keith Miller
Comment 2 2018-05-03 10:28:23 PDT
Created attachment 339424 [details] Patch
Michael Saboff
Comment 3 2018-05-03 10:36:47 PDT
Comment on attachment 339424 [details] Patch r=me
Keith Miller
Comment 4 2018-05-03 10:40:02 PDT
rdar://problem/39104634
WebKit Commit Bot
Comment 5 2018-05-03 11:18:41 PDT
Comment on attachment 339424 [details] Patch Clearing flags on attachment: 339424 Committed r231316: <https://trac.webkit.org/changeset/231316>
WebKit Commit Bot
Comment 6 2018-05-03 11:18:42 PDT
All reviewed patches have been landed. Closing bug.
Keith Miller
Comment 7 2018-05-03 17:04:16 PDT
32-bit fix in https://trac.webkit.org/r231332.
WebKit Commit Bot
Comment 8 2018-05-11 14:13:24 PDT
Re-opened since this is blocked by bug 185564
Keith Miller
Comment 9 2018-06-06 16:54:52 PDT
We are not gonna do this since it turns out this matters.
Mark Lam
Comment 10 2018-08-30 22:43:14 PDT
*** Bug 187754 has been marked as a duplicate of this bug. ***
Mark Lam
Comment 11 2018-08-31 10:13:08 PDT
For the record, ... (In reply to Keith Miller from comment #9) > We are not gonna do this since it turns out this matters. ... means this patch was rolled out in https://bugs.webkit.org/show_bug.cgi?id=185564, i.e. r231719: <https://trac.webkit.org/changeset/231719>.
Note You need to log in before you can comment on or make changes to this bug.