Bug 185215
| Summary: | The generateConditionsForPropertyBlah API should have a nicer handling of custom accessors | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> |
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | ||
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | All | ||
| OS: | All | ||
Filip Pizlo
This code smells funny:
if (!slot.isCacheableCustom()) {
conditionSet = generateConditionsForPrototypePropertyHit(
vm, codeBlock, exec, structure, slot.slotBase(),
propertyName.impl());
} else {
conditionSet = generateConditionsForPrototypePropertyHitCustom(
vm, codeBlock, exec, structure, slot.slotBase(),
propertyName.impl());
}
Maybe the `if` should be inside generateConditionsForPrototypePropertyHit.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |