Bug 185199

Summary: [iOS] Provide audio route information when invoking AirPlay picker
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, jer.noble, jonlee, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Another attempted build fix
none
Another attempted build fix
none
Another build fix none

Eric Carlson
Reported 2018-05-02 08:44:55 PDT
Provide audio route information when invoking AirPlay picker
Attachments
Patch (33.25 KB, patch)
2018-05-02 09:06 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch (33.91 KB, patch)
2018-05-02 09:45 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch (33.95 KB, patch)
2018-05-02 10:05 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch (1.83 KB, patch)
2018-05-02 12:47 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Another attempted build fix (1.35 KB, patch)
2018-05-02 14:09 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Another attempted build fix (1.36 KB, patch)
2018-05-02 14:35 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Another build fix (1.50 KB, patch)
2018-05-03 13:20 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2018-05-02 08:45:26 PDT
<rdar://problem/39853103>
Eric Carlson
Comment 2 2018-05-02 09:06:33 PDT
Created attachment 339305 [details] Patch
EWS Watchlist
Comment 3 2018-05-02 09:16:11 PDT
Attachment 339305 [details] did not pass style-queue: ERROR: Source/WebCore/platform/audio/AudioSession.cpp:117: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 1 in 30 files If any of these errors are false positives, please file a bug against check-webkit-style.
Jon Lee
Comment 4 2018-05-02 09:36:19 PDT
Comment on attachment 339305 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339305&action=review > Source/WebCore/platform/audio/AudioSession.cpp:116 > +String AudioSession::routingContextUID const missing ()!
Eric Carlson
Comment 5 2018-05-02 09:45:52 PDT
Created attachment 339308 [details] Patch
EWS Watchlist
Comment 6 2018-05-02 09:47:24 PDT
Attachment 339308 [details] did not pass style-queue: ERROR: Source/WebCore/platform/audio/mac/AudioSessionMac.cpp:135: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebCore/platform/audio/AudioSession.cpp:117: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 2 in 31 files If any of these errors are false positives, please file a bug against check-webkit-style.
Eric Carlson
Comment 7 2018-05-02 10:05:02 PDT
Created attachment 339312 [details] Patch
WebKit Commit Bot
Comment 8 2018-05-02 10:51:51 PDT
Comment on attachment 339312 [details] Patch Clearing flags on attachment: 339312 Committed r231242: <https://trac.webkit.org/changeset/231242>
WebKit Commit Bot
Comment 9 2018-05-02 10:51:52 PDT
All reviewed patches have been landed. Closing bug.
Ryan Haddad
Comment 10 2018-05-02 11:39:16 PDT
This change broke the iOS build: /Volumes/Data/slave/ios-11-release/build/Source/WebCore/platform/audio/ios/AudioSessionIOS.mm:182:45: error: instance method '-routingContextUID' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access] https://build.webkit.org/builders/Apple%20iOS%2011%20Release%20%28Build%29/builds/5825
Eric Carlson
Comment 11 2018-05-02 12:47:15 PDT
Reopening to attach new patch.
Eric Carlson
Comment 12 2018-05-02 12:47:15 PDT
Created attachment 339325 [details] Patch
WebKit Commit Bot
Comment 13 2018-05-02 13:26:37 PDT
Comment on attachment 339325 [details] Patch Clearing flags on attachment: 339325 Committed r231258: <https://trac.webkit.org/changeset/231258>
WebKit Commit Bot
Comment 14 2018-05-02 13:26:38 PDT
All reviewed patches have been landed. Closing bug.
Eric Carlson
Comment 15 2018-05-02 14:09:37 PDT
Reopening to attach new patch.
Eric Carlson
Comment 16 2018-05-02 14:09:38 PDT
Created attachment 339336 [details] Another attempted build fix
WebKit Commit Bot
Comment 17 2018-05-02 14:14:00 PDT
Comment on attachment 339336 [details] Another attempted build fix Rejecting attachment 339336 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 339336, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebCore/PAL/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.webkit.org/results/7541804
Eric Carlson
Comment 18 2018-05-02 14:35:40 PDT
Created attachment 339342 [details] Another attempted build fix
WebKit Commit Bot
Comment 19 2018-05-02 16:08:26 PDT
Comment on attachment 339342 [details] Another attempted build fix Clearing flags on attachment: 339342 Committed r231278: <https://trac.webkit.org/changeset/231278>
WebKit Commit Bot
Comment 20 2018-05-02 16:08:27 PDT
All reviewed patches have been landed. Closing bug.
Eric Carlson
Comment 21 2018-05-03 13:20:05 PDT
Reopening to attach new patch.
Eric Carlson
Comment 22 2018-05-03 13:20:05 PDT
Created attachment 339449 [details] Another build fix
WebKit Commit Bot
Comment 23 2018-05-03 13:39:39 PDT
Comment on attachment 339449 [details] Another build fix Clearing flags on attachment: 339449 Committed r231324: <https://trac.webkit.org/changeset/231324>
WebKit Commit Bot
Comment 24 2018-05-03 13:39:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.