Bug 185192

Summary: [JSC] Add compareDouble and compareFloat for ARM64, X86, and X86_64
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch mark.lam: review+

Yusuke Suzuki
Reported 2018-05-02 02:59:19 PDT
[JSC] Add compareDouble and compareFloat for ARM64, X86, and X86_64
Attachments
Patch (17.88 KB, patch)
2018-05-02 03:01 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (19.10 KB, patch)
2018-05-02 03:18 PDT, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-05-02 03:01:29 PDT
Created attachment 339294 [details] Patch
Yusuke Suzuki
Comment 2 2018-05-02 03:18:32 PDT
Created attachment 339295 [details] Patch
Mark Lam
Comment 3 2018-05-02 10:42:08 PDT
Comment on attachment 339295 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339295&action=review r=me > Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h:4162 > + return; Let's make this a RELEASE_ASSERT_NOT_REACHED().
Yusuke Suzuki
Comment 4 2018-05-02 17:44:03 PDT
Comment on attachment 339295 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339295&action=review >> Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h:4162 >> + return; > > Let's make this a RELEASE_ASSERT_NOT_REACHED(). Nice, fixed :)
Yusuke Suzuki
Comment 5 2018-05-02 17:46:14 PDT
Committed r231285: <https://trac.webkit.org/changeset/231285>
Radar WebKit Bug Importer
Comment 6 2018-05-02 17:47:26 PDT
<rdar://problem/39927061>
Yusuke Suzuki
Comment 7 2018-05-02 18:03:31 PDT
Committed r231290: <https://trac.webkit.org/changeset/231290>
Note You need to log in before you can comment on or make changes to this bug.