Bug 185186

Summary:

Use pointer instead of std::optional<std::reference_wrapper<>>

Product:

WebKit

Reporter:

Yusuke Suzuki <ysuzuki>

Component:

New Bugs

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, commit-queue, ews-watchlist, jbedard, jfbastien, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

185256

Bug Blocks:

Attachments:

Description	Flags
Patch	achristensen: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews206 for win-future	none

Yusuke Suzuki

Reported 2018-05-01 22:08:51 PDT

Use pointer instead of std::optional<std::reference_wrapper<>>

Attachments
Patch (17.67 KB, patch) 2018-05-01 22:10 PDT, Yusuke Suzuki	achristensen: review+ ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews206 for win-future (12.73 MB, application/zip) 2018-05-02 01:58 PDT, EWS Watchlist	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Yusuke Suzuki

Comment 1 2018-05-01 22:10:17 PDT

Created attachment 339277 [details] Patch

EWS Watchlist

Comment 2 2018-05-02 01:58:34 PDT

Comment on attachment 339277 [details] Patch Attachment 339277 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7534850 New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html

EWS Watchlist

Comment 3 2018-05-02 01:58:46 PDT

Created attachment 339292 [details] Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Yusuke Suzuki

Comment 4 2018-05-02 17:50:26 PDT

Committed r231288: <https://trac.webkit.org/changeset/231288>

Radar WebKit Bug Importer

Comment 5 2018-05-02 17:53:05 PDT

<rdar://problem/39927186>

WebKit Commit Bot

Comment 6 2018-05-03 09:34:32 PDT

Re-opened since this is blocked by bug 185256

Jonathan Bedard

Comment 7 2018-05-03 10:00:53 PDT

Rolled out in r231308 because r231223 was rolled out. See <https://bugs.webkit.org/show_bug.cgi?id=185159> for details.