Bug 185182

Summary: Pipe volume through PlaybackSessionManager/Proxy.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, eric.carlson, jeremyj-wk, jonlee, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jer Noble
Reported 2018-05-01 21:04:01 PDT
Pipe volume through PlaybackSessionManager/Proxy.
Attachments
Patch (16.27 KB, patch)
2018-05-01 21:06 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (22.01 KB, patch)
2018-05-01 21:07 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-05-01 21:06:09 PDT
<rdar://problem/39890630>
Jer Noble
Comment 2 2018-05-01 21:06:53 PDT
Created attachment 339268 [details] Patch
Jer Noble
Comment 3 2018-05-01 21:07:59 PDT
Created attachment 339269 [details] Patch
Sam Weinig
Comment 4 2018-05-01 21:56:08 PDT
Comment on attachment 339269 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339269&action=review > Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm:621 > + return m_playbackModel ? m_playbackModel->volume() : false; Seems weird/wrong to return false here.
Jer Noble
Comment 5 2018-05-01 21:58:38 PDT
Comment on attachment 339269 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339269&action=review >> Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm:621 >> + return m_playbackModel ? m_playbackModel->volume() : false; > > Seems weird/wrong to return false here. Brain fart. Should 0.
WebKit Commit Bot
Comment 6 2018-05-02 08:50:38 PDT
Comment on attachment 339269 [details] Patch Clearing flags on attachment: 339269 Committed r231231: <https://trac.webkit.org/changeset/231231>
WebKit Commit Bot
Comment 7 2018-05-02 08:50:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.