Bug 185175

Summary: Get the WebKit.framework bundle by asking for WKWebView
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, thorton, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Patch for landing
none
Patch for landing
none
Patch for landing none

Jer Noble
Reported 2018-05-01 16:46:10 PDT
Get the WebKit.framework bundle by asking for WKWebView
Attachments
Patch (3.83 KB, patch)
2018-05-01 16:48 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (4.20 KB, patch)
2018-05-01 17:19 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (20.56 KB, patch)
2018-05-01 17:58 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.63 KB, patch)
2018-05-01 21:11 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.76 KB, patch)
2018-05-01 21:52 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.99 KB, patch)
2018-05-02 08:25 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-05-01 16:47:20 PDT
<rdar://problem/39884149>
Jer Noble
Comment 2 2018-05-01 16:48:15 PDT
Created attachment 339243 [details] Patch
Tim Horton
Comment 3 2018-05-01 16:53:10 PDT
Comment on attachment 339243 [details] Patch What about 32-bit??
Jer Noble
Comment 4 2018-05-01 17:19:10 PDT
Created attachment 339246 [details] Patch
Tim Horton
Comment 5 2018-05-01 17:22:54 PDT
Comment on attachment 339246 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339246&action=review > Source/WebKit/StorageProcess/mac/StorageProcessMac.mm:57 > + NSBundle *webKit2Bundle = [NSBundle bundleForClass:NSClassFromString(@"WKWebView")]; Seems like this should be a helper somewhere very global, at some point (that’s what other framework projects seem to do).
Jer Noble
Comment 6 2018-05-01 17:58:42 PDT
Created attachment 339249 [details] Patch for landing
Jer Noble
Comment 7 2018-05-01 21:11:35 PDT
Created attachment 339270 [details] Patch for landing
Jer Noble
Comment 8 2018-05-01 21:52:48 PDT
Created attachment 339274 [details] Patch for landing
Jer Noble
Comment 9 2018-05-02 08:25:27 PDT
Created attachment 339302 [details] Patch for landing
WebKit Commit Bot
Comment 10 2018-05-02 10:14:16 PDT
Comment on attachment 339302 [details] Patch for landing Clearing flags on attachment: 339302 Committed r231239: <https://trac.webkit.org/changeset/231239>
WebKit Commit Bot
Comment 11 2018-05-02 10:14:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.