Bug 185143

Summary: Move the MayBePrototype JSCell header bit to InlineTypeFlags
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ews-watchlist, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Keith Miller
Reported 2018-04-30 14:57:46 PDT
Move the MayBePrototype JSCell header bit to InlineTypeFlags
Attachments
Patch (4.74 KB, patch)
2018-04-30 14:58 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (5.21 KB, patch)
2018-04-30 15:10 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2018-04-30 14:58:05 PDT
Created attachment 339150 [details] Patch
Mark Lam
Comment 2 2018-04-30 15:06:18 PDT
Comment on attachment 339150 [details] Patch r=me
Keith Miller
Comment 3 2018-04-30 15:09:55 PDT
Comment on attachment 339150 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339150&action=review > Source/JavaScriptCore/runtime/JSCellInlines.h:234 > + m_flags = structure->typeInfo().inlineTypeFlags() | (m_flags & static_cast<TypeInfo::InlineTypeFlags>(TypeInfoMayBePrototype)); I actually turned this into a function in TypeInfo since it seems a bit cleaner, are you ok with that change?
Mark Lam
Comment 4 2018-04-30 15:10:54 PDT
(In reply to Keith Miller from comment #3) > Comment on attachment 339150 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=339150&action=review > > > Source/JavaScriptCore/runtime/JSCellInlines.h:234 > > + m_flags = structure->typeInfo().inlineTypeFlags() | (m_flags & static_cast<TypeInfo::InlineTypeFlags>(TypeInfoMayBePrototype)); > > I actually turned this into a function in TypeInfo since it seems a bit > cleaner, are you ok with that change? Sounds good.
Keith Miller
Comment 5 2018-04-30 15:10:57 PDT
Created attachment 339152 [details] Patch
Keith Miller
Comment 6 2018-04-30 15:13:19 PDT
Committed r231172: <https://trac.webkit.org/changeset/231172>
Radar WebKit Bug Importer
Comment 7 2018-04-30 15:14:39 PDT
<rdar://problem/39850745>
Alex Christensen
Comment 8 2021-11-01 12:06:40 PDT
Comment on attachment 339152 [details] Patch This has been requesting review for more than one year. If this is still needed, please rebase and re-request review.
Note You need to log in before you can comment on or make changes to this bug.