| Summary: | WebProcess fails to launch | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||||||||
| Component: | WebKit2 | Assignee: | Per Arne Vollan <pvollan> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, ews-watchlist, ggaren, mitz, simon.fraser, thorton, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Per Arne Vollan
2018-04-30 11:56:01 PDT
Created attachment 339133 [details]
Patch
Comment on attachment 339133 [details]
Patch
Looks good. r=me.
Comment on attachment 339133 [details]
Patch
Thanks for reviewing!
Comment on attachment 339133 [details] Patch Clearing flags on attachment: 339133 Committed r231192: <https://trac.webkit.org/changeset/231192> All reviewed patches have been landed. Closing bug. Comment on attachment 339133 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339133&action=review > Source/WebKit/Configurations/WebContentService.xcconfig:64 > +RUNLOOP_TYPE = $(RUNLOOP_TYPE_$(PLATFORM_NAME)_$(TARGET_MAC_OS_X_VERSION_MAJOR)); We avoid using TARGET_MAC_OS_X_VERSION_MAJOR like this because it’s not future-proof. Please use the WK_MACOS_* machinery defined in WebKitTargetConditionals.xcconfig as described in the comments there. Reopening to attach new patch. Created attachment 339204 [details]
Patch
(In reply to mitz from comment #7) > Comment on attachment 339133 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=339133&action=review > > > Source/WebKit/Configurations/WebContentService.xcconfig:64 > > +RUNLOOP_TYPE = $(RUNLOOP_TYPE_$(PLATFORM_NAME)_$(TARGET_MAC_OS_X_VERSION_MAJOR)); > > We avoid using TARGET_MAC_OS_X_VERSION_MAJOR like this because it’s not > future-proof. Please use the WK_MACOS_* machinery defined in > WebKitTargetConditionals.xcconfig as described in the comments there. Thanks! I have updated the patch. Comment on attachment 339204 [details]
Patch
Very cool! r=me
Comment on attachment 339204 [details] Patch Attachment 339204 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7526510 New failing tests: http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html fast/dom/URL-attribute-reflection.html http/tests/security/contentSecurityPolicy/video-with-https-url-allowed-by-csp-media-src-star.html Created attachment 339213 [details]
Archive of layout-test-results from ews206 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 339204 [details] Patch Clearing flags on attachment: 339204 Committed r231205: <https://trac.webkit.org/changeset/231205> All reviewed patches have been landed. Closing bug. This is still a problem. Created attachment 340727 [details]
Patch
Comment on attachment 340727 [details]
Patch
r=me
Can we test this -- or is it observable in an existing crash?
Comment on attachment 340727 [details] Patch Clearing flags on attachment: 340727 Committed r231984: <https://trac.webkit.org/changeset/231984> All reviewed patches have been landed. Closing bug. |