Bug 185136

Summary: [MediaStream] remove WK1 support
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, rniwa, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
youennf: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews107 for mac-sierra-wk2
none
Patch
none
Archive of layout-test-results from ews100 for mac-sierra
none
Archive of layout-test-results from ews112 for mac-sierra
none
Patch none

Eric Carlson
Reported 2018-04-30 09:59:12 PDT
getUserMedia has never worked in webKit1 and we don't plan to add support, so remove all of the WK1-only code.
Attachments
Patch (34.36 KB, text/plain)
2018-04-30 10:03 PDT, Eric Carlson 		youennf: review+
ews-watchlist: commit-queue-
Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (2.64 MB, application/zip)
2018-04-30 10:47 PDT, EWS Watchlist 		no flags
Details
Patch (23.39 KB, patch)
2018-04-30 14:42 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews100 for mac-sierra (2.49 MB, application/zip)
2018-04-30 15:53 PDT, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews112 for mac-sierra (3.13 MB, application/zip)
2018-04-30 16:27 PDT, EWS Watchlist 		no flags
Details
Patch (23.99 KB, patch)
2018-05-01 09:20 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2018-04-30 10:03:06 PDT
Created attachment 339120 [details] Patch
youenn fablet
Comment 2 2018-04-30 10:18:29 PDT
Comment on attachment 339120 [details] Patch r=me once the bots are happy. View in context: https://bugs.webkit.org/attachment.cgi?id=339120&action=review > Source/WebKitLegacy/mac/WebView/WebView.mm:3038 > + DeprecatedGlobalSettings::setMediaCaptureRequiresSecureConnection(true); These two are probably not needed since the below runtime flags are set to false.
EWS Watchlist
Comment 3 2018-04-30 10:47:58 PDT
Comment on attachment 339120 [details] Patch Attachment 339120 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7508903 Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 4 2018-04-30 10:47:59 PDT
Created attachment 339126 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Eric Carlson
Comment 5 2018-04-30 14:42:14 PDT
Created attachment 339148 [details] Patch
EWS Watchlist
Comment 6 2018-04-30 15:53:36 PDT
Comment on attachment 339148 [details] Patch Attachment 339148 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7516049 New failing tests: fast/events/constructors/media-stream-event-constructor.html
EWS Watchlist
Comment 7 2018-04-30 15:53:37 PDT
Created attachment 339157 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 8 2018-04-30 16:27:54 PDT
Comment on attachment 339148 [details] Patch Attachment 339148 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/7516207 New failing tests: fast/events/constructors/media-stream-event-constructor.html
EWS Watchlist
Comment 9 2018-04-30 16:27:55 PDT
Created attachment 339161 [details] Archive of layout-test-results from ews112 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-sierra Platform: Mac OS X 10.12.6
Eric Carlson
Comment 10 2018-05-01 09:20:53 PDT
Created attachment 339201 [details] Patch
WebKit Commit Bot
Comment 11 2018-05-01 10:27:18 PDT
Comment on attachment 339201 [details] Patch Clearing flags on attachment: 339201 Committed r231201: <https://trac.webkit.org/changeset/231201>
WebKit Commit Bot
Comment 12 2018-05-01 10:27:20 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 13 2018-05-01 10:28:42 PDT
<rdar://problem/39870021>
Note You need to log in before you can comment on or make changes to this bug.