Bug 185111

Summary: PSON: Make WebKitTestRunner work with process swap on navigation turned on
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, beidson, cdumez, commit-queue, ggaren, lforschler, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Adds the basic support
none
Updated for ToT
none
Added forgotten WhatToDump.h none

Ryosuke Niwa
Reported 2018-04-28 01:19:19 PDT
Add the basic support for running layout tests with process-swap-on-navigation turned on.
Attachments
Adds the basic support (31.52 KB, patch)
2018-04-28 01:46 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Updated for ToT (31.48 KB, patch)
2018-04-30 12:15 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Added forgotten WhatToDump.h (33.29 KB, patch)
2018-04-30 13:36 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2018-04-28 01:46:38 PDT
Created attachment 339062 [details] Adds the basic support
Radar WebKit Bug Importer
Comment 2 2018-04-28 01:47:15 PDT
<rdar://problem/39815667>
Alexey Proskuryakov
Comment 3 2018-04-28 09:12:54 PDT
What is the performance impact of this change?
Ryosuke Niwa
Comment 4 2018-04-29 11:40:41 PDT
(In reply to Alexey Proskuryakov from comment #3) > What is the performance impact of this change? I'm gonna measure that on Monday. I suspect one extra IPC wouldn't do much but I agree that's one concerning aspect of this change.
Ryosuke Niwa
Comment 5 2018-04-29 11:41:09 PDT
Comment on attachment 339062 [details] Adds the basic support Gotta rebase to trunk :(
Ryosuke Niwa
Comment 6 2018-04-30 12:15:54 PDT
Created attachment 339135 [details] Updated for ToT
Ryosuke Niwa
Comment 7 2018-04-30 13:36:54 PDT
Created attachment 339143 [details] Added forgotten WhatToDump.h
Ryosuke Niwa
Comment 8 2018-05-01 11:00:07 PDT
(In reply to Ryosuke Niwa from comment #4) > (In reply to Alexey Proskuryakov from comment #3) > > What is the performance impact of this change? > > I'm gonna measure that on Monday. I suspect one extra IPC wouldn't do much > but I agree that's one concerning aspect of this change. Appears to be ~1% increase in debug build, which is probably negligible. Without pach: Mon Apr 30 19:19:03 PDT 2018 Mon Apr 30 21:23:21 PDT 2018 7458000 With patch: Mon Apr 30 21:23:57 PDT 2018 Mon Apr 30 23:29:30 PDT 2018 7533000 1% increase Gonna measure release build next.
Ryosuke Niwa
Comment 9 2018-05-01 19:25:29 PDT
Without patch: Tue May 1 12:44:48 PDT 2018 Tue May 1 14:01:22 PDT 2018 4594000 Tue May 1 15:01:39 PDT 2018 Tue May 1 16:18:45 PDT 2018 4626000 ~0.6% increase.
Ryosuke Niwa
Comment 10 2018-05-01 20:02:58 PDT
Ping reviewers?
WebKit Commit Bot
Comment 11 2018-05-01 21:05:46 PDT
Comment on attachment 339143 [details] Added forgotten WhatToDump.h Clearing flags on attachment: 339143 Committed r231222: <https://trac.webkit.org/changeset/231222>
WebKit Commit Bot
Comment 12 2018-05-01 21:05:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.