Summary: | Drop toJS() functions taking a DOMWindow parameter | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||
Component: | Bindings | Assignee: | Chris Dumez <cdumez> | ||||||||||
Status: | RESOLVED INVALID | ||||||||||||
Severity: | Normal | CC: | cdumez, ews-watchlist, ggaren, rniwa, sam | ||||||||||
Priority: | P2 | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | 185022 | ||||||||||||
Bug Blocks: | |||||||||||||
Attachments: |
|
Description
Chris Dumez
2018-04-27 19:31:44 PDT
Created attachment 339051 [details]
Patch
Comment on attachment 339051 [details] Patch Attachment 339051 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/7487270 Number of test failures exceeded the failure limit. Created attachment 339054 [details]
Archive of layout-test-results from ews117 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 339051 [details] Patch Attachment 339051 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7487289 Number of test failures exceeded the failure limit. Created attachment 339055 [details]
Archive of layout-test-results from ews102 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 339051 [details] Patch Attachment 339051 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7487459 Number of test failures exceeded the failure limit. Created attachment 339057 [details]
Archive of layout-test-results from ews205 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Looks like we still need it because of toJS(ExecState*, JSDOMGlobalObject*, EventTarget&). |