Bug 185102

Summary:

Drop toJS() functions taking a DOMWindow parameter

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Bindings

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

cdumez, ews-watchlist, ggaren, rniwa, sam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

185022

Bug Blocks:

Attachments:

Description	Flags
Patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews117 for mac-sierra	none
Archive of layout-test-results from ews102 for mac-sierra	none
Archive of layout-test-results from ews205 for win-future	none

Chris Dumez

Reported 2018-04-27 19:31:44 PDT

Drop toJS() functions taking a DOMWindow parameter as our implementation should always be returning WindowProxy objects now.

Attachments
Patch (7.85 KB, patch) 2018-04-27 19:36 PDT, Chris Dumez	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews117 for mac-sierra (340.12 KB, application/zip) 2018-04-27 20:35 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews102 for mac-sierra (793.36 KB, application/zip) 2018-04-27 20:47 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews205 for win-future (321.80 KB, application/zip) 2018-04-27 21:22 PDT, EWS Watchlist	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2018-04-27 19:36:10 PDT

Created attachment 339051 [details] Patch

EWS Watchlist

Comment 2 2018-04-27 20:35:25 PDT

Comment on attachment 339051 [details] Patch Attachment 339051 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/7487270 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 3 2018-04-27 20:35:26 PDT

Created attachment 339054 [details] Archive of layout-test-results from ews117 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 4 2018-04-27 20:47:29 PDT

Comment on attachment 339051 [details] Patch Attachment 339051 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7487289 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 5 2018-04-27 20:47:30 PDT

Created attachment 339055 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 6 2018-04-27 21:22:00 PDT

Comment on attachment 339051 [details] Patch Attachment 339051 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7487459 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 7 2018-04-27 21:22:01 PDT

Created attachment 339057 [details] Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Chris Dumez

Comment 8 2018-04-27 21:36:03 PDT

Looks like we still need it because of toJS(ExecState*, JSDOMGlobalObject*, EventTarget&).

Note You need to log in before you can comment on or make changes to this bug.