Bug 185100

Summary: Add logging when SpringBoard enables WebThread
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebCore Misc.Assignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=186793
Attachments:
Description Flags
Patch v1
none
Patch v2 none

Description David Kilzer (:ddkilzer) 2018-04-27 17:13:18 PDT
Add logging when SpringBoard enables WebThread.

<rdar://problem/39746542>
Comment 1 David Kilzer (:ddkilzer) 2018-04-27 17:19:08 PDT
Created attachment 339043 [details]
Patch v1
Comment 2 Daniel Bates 2018-04-27 19:34:59 PDT
Comment on attachment 339043 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=339043&action=review

> Source/WTF/ChangeLog:5
> +        <rdar://problem/39746542>

I assume if I were to look at this bug that it would explain why it is beneficial to add this logging.

> Source/WTF/wtf/Platform.h:-1266
> -/* FIXME: Enable USE_OS_LOG when building with the public iOS 10 SDK once we fix <rdar://problem/27758343>. */

Not at my computer. I am assuming we fixed the referenced radar and hence we can enable this. The ChangeLog didn’t mention this fact and EWS failed to compile this patch for iOS due to another issue below.

> Source/WebCore/platform/ios/wak/WebCoreThread.mm:880
> +        RELEASE_LOG_FAULT(Threading, "SpringBoard enabled WebThread.");

According to the EWS we don’t have a logging channel called Threading.
Comment 3 David Kilzer (:ddkilzer) 2018-04-27 20:14:16 PDT
Comment on attachment 339043 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=339043&action=review

>> Source/WTF/ChangeLog:5
>> +        <rdar://problem/39746542>
> 
> I assume if I were to look at this bug that it would explain why it is beneficial to add this logging.

Correct.  Added more detail just now as well.

>> Source/WTF/wtf/Platform.h:-1266
>> -/* FIXME: Enable USE_OS_LOG when building with the public iOS 10 SDK once we fix <rdar://problem/27758343>. */
> 
> Not at my computer. I am assuming we fixed the referenced radar and hence we can enable this. The ChangeLog didn’t mention this fact and EWS failed to compile this patch for iOS due to another issue below.

Yes, it's fixed.  I'll add a comment to the ChangeLog.

>> Source/WebCore/platform/ios/wak/WebCoreThread.mm:880
>> +        RELEASE_LOG_FAULT(Threading, "SpringBoard enabled WebThread.");
> 
> According to the EWS we don’t have a logging channel called Threading.

Weird.  I thought it was defined here:  Source/WebCore/platform/Logging.h

Maybe I forgot to #include that.
Comment 4 David Kilzer (:ddkilzer) 2018-04-27 20:30:15 PDT
Created attachment 339053 [details]
Patch v2
Comment 5 David Kilzer (:ddkilzer) 2018-04-27 20:38:37 PDT
(In reply to David Kilzer (:ddkilzer) from comment #4)
> Created attachment 339053 [details]
> Patch v2

Added missing #import "Logging.h" to WebCoreThread.mm to fix the iOS build failures.

Also updated Source/WTF/ChangeLog with info about the fixed radar.
Comment 6 WebKit Commit Bot 2018-04-27 22:53:09 PDT
Comment on attachment 339053 [details]
Patch v2

Clearing flags on attachment: 339053

Committed r231130: <https://trac.webkit.org/changeset/231130>
Comment 7 WebKit Commit Bot 2018-04-27 22:53:10 PDT
All reviewed patches have been landed.  Closing bug.