Bug 185092

Summary: Implement animation for color-filter
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, dstockwell, ews-watchlist, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch thorton: review+

Description Simon Fraser (smfr) 2018-04-27 14:37:08 PDT
Implement animation for color-filter
Comment 1 Simon Fraser (smfr) 2018-04-27 14:40:40 PDT
Created attachment 339031 [details]
Patch
Comment 2 Simon Fraser (smfr) 2018-04-27 14:41:08 PDT
rdar://problem/39773810
Comment 3 Simon Fraser (smfr) 2018-04-27 14:57:50 PDT
Created attachment 339032 [details]
Patch
Comment 4 EWS Watchlist 2018-04-27 14:59:30 PDT
Attachment 339032 [details] did not pass style-queue:


ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:699:  Line contains only semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Tim Horton 2018-04-27 15:55:52 PDT
Comment on attachment 339032 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339032&action=review

> Source/WebCore/ChangeLog:14
> +        The filter-related ProperyWappers in CSSPropertyAnimation are cleaned up to use a single wrapper,

nice!

> Source/WebCore/ChangeLog:16
> +        This wrapper reports that its accelerated for filter and backdrop-filter, but not color-filter.

its accelerated what
Comment 6 Simon Fraser (smfr) 2018-04-27 17:28:21 PDT
https://trac.webkit.org/changeset/231123/webkit