Bug 185092 - Implement animation for color-filter
Summary: Implement animation for color-filter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-27 14:37 PDT by Simon Fraser (smfr)
Modified: 2018-04-27 17:28 PDT (History)
6 users (show)

See Also:

Attachments
Patch (21.94 KB, patch)
2018-04-27 14:40 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (22.11 KB, patch)
2018-04-27 14:57 PDT, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2018-04-27 14:37:08 PDT 
Implement animation for color-filter
Comment 1 Simon Fraser (smfr) 2018-04-27 14:40:40 PDT 
Created attachment 339031 [details]
Patch
Comment 2 Simon Fraser (smfr) 2018-04-27 14:41:08 PDT 
rdar://problem/39773810
Comment 3 Simon Fraser (smfr) 2018-04-27 14:57:50 PDT 
Created attachment 339032 [details]
Patch
Comment 4 EWS Watchlist 2018-04-27 14:59:30 PDT 
Attachment 339032 [details] did not pass style-queue:


ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:699:  Line contains only semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Tim Horton 2018-04-27 15:55:52 PDT 
Comment on attachment 339032 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339032&action=review

> Source/WebCore/ChangeLog:14
> +        The filter-related ProperyWappers in CSSPropertyAnimation are cleaned up to use a single wrapper,

nice!

> Source/WebCore/ChangeLog:16
> +        This wrapper reports that its accelerated for filter and backdrop-filter, but not color-filter.

its accelerated what
Comment 6 Simon Fraser (smfr) 2018-04-27 17:28:21 PDT 
https://trac.webkit.org/changeset/231123/webkit