Bug 185057
| Summary: | Style checker has issue with test implementation files with no primary headers | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Megan Gardner <megan_gardner> |
| Component: | Tools / Tests | Assignee: | Kimmo Kinnunen <kkinnunen> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ap, commit-queue, jbedard, kkinnunen, lforschler, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 247971 | ||
| Bug Blocks: | 246947 | ||
Megan Gardner
If you have a file that does not have a header, like an API test, the style checker will get upset that the first header doesn't match. But there is not header to include, so it should be ok as long as the list is alphabetical after config.h.
I ran into this with SynchronousTimeoutTests.mm
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/101670878>
Kimmo Kinnunen
Pull request: https://github.com/WebKit/WebKit/pull/5896
EWS
Committed 256128@main (2419e966a284): <https://commits.webkit.org/256128@main>
Reviewed commits have been landed. Closing PR #5896 and removing active labels.
WebKit Commit Bot
Re-opened since this is blocked by bug 247971